You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/10/19 20:38:36 UTC

[GitHub] [beam] pabloem opened a new pull request, #23737: Speed up check on website links

pabloem opened a new pull request, #23737:
URL: https://github.com/apache/beam/pull/23737

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on a diff in pull request #23737: Speed up check on website links

Posted by GitBox <gi...@apache.org>.
pabloem commented on code in PR #23737:
URL: https://github.com/apache/beam/pull/23737#discussion_r999943012


##########
website/www/check-links.sh:
##########
@@ -73,7 +73,7 @@ for external_link in "${external_links[@]}"
 do
     redraw_progress_bar 50 1 $i ${#external_links[@]}
 
-    if ! curl -sSfL --max-time 10 --connect-timeout 10 --retry 2 -4 "${external_link}" > /dev/null ; then
+    if ! curl -sSfL --max-filesize 2000000 --max-time 10 --connect-timeout 10 --retry 2 -4 "${external_link}" > /dev/null ; then

Review Comment:
   done. adjusted to 1mb



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on pull request #23737: Speed up check on website links

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23737:
URL: https://github.com/apache/beam/pull/23737#issuecomment-1284576270

   r @damccorm - this should also let us skip files that are very large to speed up the checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on a diff in pull request #23737: Speed up check on website links

Posted by GitBox <gi...@apache.org>.
pabloem commented on code in PR #23737:
URL: https://github.com/apache/beam/pull/23737#discussion_r999940923


##########
website/www/check-links.sh:
##########
@@ -73,7 +73,7 @@ for external_link in "${external_links[@]}"
 do
     redraw_progress_bar 50 1 $i ${#external_links[@]}
 
-    if ! curl -sSfL --max-time 10 --connect-timeout 10 --retry 2 -4 "${external_link}" > /dev/null ; then
+    if ! curl -sSfL --max-filesize 2000000 --max-time 10 --connect-timeout 10 --retry 2 -4 "${external_link}" > /dev/null ; then

Review Comment:
   correct. curl errors out in that scenario, which causes the files to be added to the list of troublemakers - but I think this may be fine. I can add some printed output and comments stating this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem merged pull request #23737: Speed up check on website links

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #23737:
URL: https://github.com/apache/beam/pull/23737


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on a diff in pull request #23737: Speed up check on website links

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23737:
URL: https://github.com/apache/beam/pull/23737#discussion_r999937373


##########
website/www/check-links.sh:
##########
@@ -73,7 +73,7 @@ for external_link in "${external_links[@]}"
 do
     redraw_progress_bar 50 1 $i ${#external_links[@]}
 
-    if ! curl -sSfL --max-time 10 --connect-timeout 10 --retry 2 -4 "${external_link}" > /dev/null ; then
+    if ! curl -sSfL --max-filesize 2000000 --max-time 10 --connect-timeout 10 --retry 2 -4 "${external_link}" > /dev/null ; then

Review Comment:
   What happens for files greater than this size? If the answer is just, they don't get downloaded, can we set this even lower?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org