You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Haode Du (Jira)" <ji...@apache.org> on 2023/09/06 17:40:00 UTC
[jira] [Commented] (FLINK-33000) SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory
[ https://issues.apache.org/jira/browse/FLINK-33000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762468#comment-17762468 ]
Haode Du commented on FLINK-33000:
----------------------------------
Hi [~mapohl], I would like to work on this issue as a starter. I would appreciate that if a more detailed background or guidance could be offered
> SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory
> ---------------------------------------------------------------------------------------------
>
> Key: FLINK-33000
> URL: https://issues.apache.org/jira/browse/FLINK-33000
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Gateway, Tests
> Affects Versions: 1.16.2, 1.18.0, 1.17.1, 1.19.0
> Reporter: Matthias Pohl
> Priority: Major
> Labels: starter
>
> {{SqlGatewayServiceITCase}} uses a {{ExecutorThreadFactory}} for its asynchronous operations. Instead, one should use {{TestExecutorExtension}} to ensure proper cleanup of threads.
> We might also want to remove the {{AbstractTestBase}} parent class because that uses JUnit4 whereas {{SqlGatewayServiceITCase}} is already based on JUnit5
--
This message was sent by Atlassian Jira
(v8.20.10#820010)