You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Pino Silvaggio (JIRA)" <ji...@apache.org> on 2008/01/12 09:46:34 UTC
[jira] Created: (SANDBOX-207) Line number is wrong when last line
doesn't contain \n
Line number is wrong when last line doesn't contain \n
------------------------------------------------------
Key: SANDBOX-207
URL: https://issues.apache.org/jira/browse/SANDBOX-207
Project: Commons Sandbox
Issue Type: Bug
Components: CSV
Reporter: Pino Silvaggio
Line number is wrong when last line doesn't contain \n
The line number returned is the same as the previous line
since it has not been incremented. This is because it
uses the ExtendedBufferReader which increments
lines based on "\n" which is somewhat wrong...
Refer to: http://tools.ietf.org/html/rfc4180
It permits the last line not to have a CRLF.
I would submit a patch for this but will it be ignored?
Should I make time for this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SANDBOX-207) Line number is wrong when last line
doesn't contain \n
Posted by "Pino Silvaggio (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pino Silvaggio closed SANDBOX-207.
----------------------------------
Resolution: Invalid
After some thoughts it was hasty of me to report a bug for this.
It's not a bug since the getLineNumber() clearly states
it report the underlying stream line # which is ok
but as a parser it would be nice to get the
current record line #.
> Line number is wrong when last line doesn't contain \n
> ------------------------------------------------------
>
> Key: SANDBOX-207
> URL: https://issues.apache.org/jira/browse/SANDBOX-207
> Project: Commons Sandbox
> Issue Type: Bug
> Components: CSV
> Reporter: Pino Silvaggio
>
> Line number is wrong when last line doesn't contain \n
> The line number returned is the same as the previous line
> since it has not been incremented. This is because it
> uses the ExtendedBufferReader which increments
> lines based on "\n" which is somewhat wrong...
> Refer to: http://tools.ietf.org/html/rfc4180
> It permits the last line not to have a CRLF.
> I would submit a patch for this but will it be ignored?
> Should I make time for this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SANDBOX-207) Line number is wrong when last line
doesn't contain \n
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANDBOX-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558271#action_12558271 ]
Henri Yandell commented on SANDBOX-207:
---------------------------------------
Won't be ignored - patches very welcome.
> Line number is wrong when last line doesn't contain \n
> ------------------------------------------------------
>
> Key: SANDBOX-207
> URL: https://issues.apache.org/jira/browse/SANDBOX-207
> Project: Commons Sandbox
> Issue Type: Bug
> Components: CSV
> Reporter: Pino Silvaggio
>
> Line number is wrong when last line doesn't contain \n
> The line number returned is the same as the previous line
> since it has not been incremented. This is because it
> uses the ExtendedBufferReader which increments
> lines based on "\n" which is somewhat wrong...
> Refer to: http://tools.ietf.org/html/rfc4180
> It permits the last line not to have a CRLF.
> I would submit a patch for this but will it be ignored?
> Should I make time for this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.