[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9031: [fix] Pivot table metric ordering

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #9031: [fix] Pivot table metric ordering
URL: https://github.com/apache/incubator-superset/pull/9031#discussion_r371614850
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -676,7 +676,7 @@ def query_obj(self):
             )
         if not metrics:
             raise Exception(_("Please choose at least one metric"))
-        if any(v in groupby for v in columns) or any(v in columns for v in groupby):
+        if set(groupby) & set(columns):
 
 Review comment:
   This is the same logic but in a more condensed form.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org