You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/28 21:20:36 UTC

[GitHub] dilipbiswal opened a new pull request #23925: [SPARK-27016] Treat all antlr warnings as errors while generating parser from the sql grammar file.

dilipbiswal opened a new pull request #23925: [SPARK-27016] Treat all antlr warnings as errors while generating parser from the sql grammar file.
URL: https://github.com/apache/spark/pull/23925
 
 
   ## What changes were proposed in this pull request?
   Use the maven plugin option `treatWarningsAsErrors` to make sure the warnings are treated as errors while generating the parser file. In the absence of it, we may inadvertently introducing problems while making grammar changes.  Please refer to [PR-23897](https://github.com/apache/spark/pull/23897) to know more about the context.
   ## How was this patch tested?
   Verified this after applying [PR](https://github.com/apache/spark/pull/23897)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org