[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9322: fix: handle list of lists from fetch_data

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #9322: fix: handle list of lists from fetch_data
URL: https://github.com/apache/incubator-superset/pull/9322#discussion_r394298221
 
 

 ##########
 File path: tests/result_set_tests.py
 ##########
 @@ -109,6 +109,13 @@ def test_int64_with_missing_data(self):
         results = SupersetResultSet(data, cursor_descr, BaseEngineSpec)
         self.assertEqual(results.columns[0]["type"], "BIGINT")
 
+    def test_data_from_list_of_lists(self):
+        data = [["a"], ["b"]]
+        cursor_descr = [("user_id", "STRING", None, None, None, None, True)]
 
 Review comment:
   We can add another test for cursor descriptions that use `List[List[]]`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org