You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/11/21 19:09:09 UTC
[commons-digester] branch master updated: Use a String instead of
building one.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-digester.git
The following commit(s) were added to refs/heads/master by this push:
new da5da46 Use a String instead of building one.
da5da46 is described below
commit da5da4620fbdd783bb82155c2844f0023c209fb8
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Nov 21 14:09:05 2020 -0500
Use a String instead of building one.
---
.../org/apache/commons/digester3/DigesterTestCase.java | 12 ++++++------
.../commons/digester3/ObjectParamRuleTestCase.java | 8 ++++----
.../org/apache/commons/digester3/TestFactoryCreate.java | 16 ++++++++--------
3 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/core/src/test/java/org/apache/commons/digester3/DigesterTestCase.java b/core/src/test/java/org/apache/commons/digester3/DigesterTestCase.java
index dfa39ce..f38d8ce 100644
--- a/core/src/test/java/org/apache/commons/digester3/DigesterTestCase.java
+++ b/core/src/test/java/org/apache/commons/digester3/DigesterTestCase.java
@@ -654,13 +654,13 @@ public class DigesterTestCase
{
final TrackingStackAction action = new TrackingStackAction();
- final Object obj1 = new String( "obj1" );
- final Object obj2 = new String( "obj2" );
- final Object obj3 = new String( "replpop.obj3" );
- final Object obj4 = new String( "replpush.obj4" );
+ final Object obj1 = "obj1";
+ final Object obj2 = "obj2";
+ final Object obj3 = "replpop.obj3";
+ final Object obj4 = "replpush.obj4";
- final Object obj8 = new String( "obj8" );
- final Object obj9 = new String( "obj9" );
+ final Object obj8 = "obj8";
+ final Object obj9 = "obj9";
final Digester d = new Digester();
d.setStackAction( action );
diff --git a/core/src/test/java/org/apache/commons/digester3/ObjectParamRuleTestCase.java b/core/src/test/java/org/apache/commons/digester3/ObjectParamRuleTestCase.java
index 6193cf3..07de3a3 100644
--- a/core/src/test/java/org/apache/commons/digester3/ObjectParamRuleTestCase.java
+++ b/core/src/test/java/org/apache/commons/digester3/ObjectParamRuleTestCase.java
@@ -71,10 +71,10 @@ public class ObjectParamRuleTestCase
.objectParam( new Long( 999999999 ) );
forPattern( "arraylist/D" ).callMethod( "add" ).withParamCount( 1 )
.then()
- .objectParam( new String( "foobarbazbing" ) ).matchingAttribute( "desc" );
+ .objectParam( "foobarbazbing" ).matchingAttribute( "desc" );
forPattern( "arraylist/E" ).callMethod( "add" ).withParamCount( 1 )
.then()
- .objectParam( new String( "ignore" ) ).matchingAttribute( "nonexistentattribute" );
+ .objectParam( "ignore" ).matchingAttribute( "nonexistentattribute" );
}
}).newDigester();
@@ -86,8 +86,8 @@ public class ObjectParamRuleTestCase
assertTrue( al.contains( new Integer( -9 ) ) );
assertTrue( al.contains( new Float( 3.14159 ) ) );
assertTrue( al.contains( new Long( 999999999 ) ) );
- assertTrue( al.contains( new String( "foobarbazbing" ) ) );
- assertTrue( !( al.contains( new String( "ignore" ) ) ) );
+ assertTrue( al.contains( "foobarbazbing" ) );
+ assertTrue( !( al.contains( "ignore" ) ) );
}
}
diff --git a/core/src/test/java/org/apache/commons/digester3/TestFactoryCreate.java b/core/src/test/java/org/apache/commons/digester3/TestFactoryCreate.java
index 5390a36..c6324ed 100644
--- a/core/src/test/java/org/apache/commons/digester3/TestFactoryCreate.java
+++ b/core/src/test/java/org/apache/commons/digester3/TestFactoryCreate.java
@@ -114,7 +114,7 @@ public class TestFactoryCreate
Digester digester = new Digester();
ObjectCreationFactoryTestImpl factory = new ObjectCreationFactoryTestImpl();
digester.addFactoryCreate( "root", factory, ignoreCreateExceptions );
- String xml = new String( "<?xml version='1.0' ?><root one='good' two='bad' three='ugly'><element/></root>" );
+ String xml = "<?xml version='1.0' ?><root one='good' two='bad' three='ugly'><element/></root>";
digester.parse( new StringReader( xml ) );
assertEquals( "Object create not called(1)[" + ignoreCreateExceptions + "]", factory.called, true );
@@ -129,7 +129,7 @@ public class TestFactoryCreate
digester.addFactoryCreate( "root", "org.apache.commons.digester3.ObjectCreationFactoryTestImpl",
ignoreCreateExceptions );
digester.addSetNext( "root", "add" );
- xml = new String( "<?xml version='1.0' ?><root one='good' two='bad' three='ugly'><element/></root>" );
+ xml = "<?xml version='1.0' ?><root one='good' two='bad' three='ugly'><element/></root>";
List<ObjectCreationFactoryTestImpl> list = new ArrayList<ObjectCreationFactoryTestImpl>();
digester.push( list );
digester.parse( new StringReader( xml ) );
@@ -148,7 +148,7 @@ public class TestFactoryCreate
digester.addFactoryCreate( "root", "org.apache.commons.digester3.ObjectCreationFactoryTestImpl", "override",
ignoreCreateExceptions );
digester.addSetNext( "root", "add" );
- xml = new String( "<?xml version='1.0' ?><root one='good' two='bad' three='ugly'><element/></root>" );
+ xml = "<?xml version='1.0' ?><root one='good' two='bad' three='ugly'><element/></root>";
list = new ArrayList<ObjectCreationFactoryTestImpl>();
digester.push( list );
digester.parse( new StringReader( xml ) );
@@ -168,8 +168,8 @@ public class TestFactoryCreate
ignoreCreateExceptions );
digester.addSetNext( "root", "add" );
xml =
- new String( "<?xml version='1.0' ?><root one='good' two='bad' three='ugly' "
- + " override='org.apache.commons.digester3.OtherTestObjectCreationFactory' >" + "<element/></root>" );
+ ("<?xml version='1.0' ?><root one='good' two='bad' three='ugly' "
+ + " override='org.apache.commons.digester3.OtherTestObjectCreationFactory' >" + "<element/></root>");
list = new ArrayList<ObjectCreationFactoryTestImpl>();
digester.push( list );
digester.parse( new StringReader( xml ) );
@@ -189,7 +189,7 @@ public class TestFactoryCreate
digester = new Digester();
digester.addFactoryCreate( "root", ObjectCreationFactoryTestImpl.class, "override", ignoreCreateExceptions );
digester.addSetNext( "root", "add" );
- xml = new String( "<?xml version='1.0' ?><root one='good' two='bad' three='ugly'><element/></root>" );
+ xml = "<?xml version='1.0' ?><root one='good' two='bad' three='ugly'><element/></root>";
list = new ArrayList<ObjectCreationFactoryTestImpl>();
digester.push( list );
digester.parse( new StringReader( xml ) );
@@ -208,8 +208,8 @@ public class TestFactoryCreate
digester.addFactoryCreate( "root", ObjectCreationFactoryTestImpl.class, "override", ignoreCreateExceptions );
digester.addSetNext( "root", "add" );
xml =
- new String( "<?xml version='1.0' ?><root one='good' two='bad' three='ugly' "
- + " override='org.apache.commons.digester3.OtherTestObjectCreationFactory' >" + "<element/></root>" );
+ ("<?xml version='1.0' ?><root one='good' two='bad' three='ugly' "
+ + " override='org.apache.commons.digester3.OtherTestObjectCreationFactory' >" + "<element/></root>");
list = new ArrayList<ObjectCreationFactoryTestImpl>();
digester.push( list );
digester.parse( new StringReader( xml ) );