You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/08 04:12:27 UTC

[GitHub] [cloudstack-primate] utchoang opened a new pull request #399: Force delete template/iso missing

utchoang opened a new pull request #399:
URL: https://github.com/apache/cloudstack-primate/pull/399


   Open for https://github.com/apache/cloudstack-primate/issues/384
   @rhtyd cc @svenvogel I've completed this task. Thanks.
   ![image](https://user-images.githubusercontent.com/13766648/83991995-e1f01a00-a978-11ea-910d-874788d78560.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #399: Force delete template/iso missing

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #399:
URL: https://github.com/apache/cloudstack-primate/pull/399


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #399: Force delete template/iso missing

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #399:
URL: https://github.com/apache/cloudstack-primate/pull/399#issuecomment-640365464


   Thanks, LGTM will test and merge
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #399: Force delete template/iso missing

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #399:
URL: https://github.com/apache/cloudstack-primate/pull/399#issuecomment-640365738


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #399: Force delete template/iso missing

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #399:
URL: https://github.com/apache/cloudstack-primate/pull/399#discussion_r439345218



##########
File path: src/views/image/TemplateZones.vue
##########
@@ -110,6 +101,24 @@
         </a-form>
       </a-spin>
     </a-modal>
+
+    <a-modal
+      v-if="'deleteTemplate' in $store.getters.apis"

Review comment:
       Adding `v-if` in modal itself will make delete button visible irrespective user access.
   It is showing for read-only admin user
   ![Screenshot from 2020-06-12 16-13-44](https://user-images.githubusercontent.com/153340/84494891-e180b780-acc7-11ea-84ed-c25ee3c7f8a0.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #399: Force delete template/iso missing

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #399:
URL: https://github.com/apache/cloudstack-primate/pull/399#issuecomment-640368512


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/399 (JID-1983)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org