[GitHub] [druid] a2l007 commented on issue #10294: Failed Query due to missing lookup on some servers

[GitBox <gi...@apache.org>]

a2l007 commented on issue #10294:
URL: https://github.com/apache/druid/issues/10294#issuecomment-698393448


   From an overall review of the PR #10428 , the design looks reasonable to me, because it minimizes the changes in core druid and separates out the lookup filtering changes into an extension. Once a queryableDruidServer for the first segment specific to a query is picked, the subsequent pick calls for that query might not need the query object for making the pick decision, so it would be good to have some kind of caching in the extension. 
   It looks useful to me, but I'll wait for other reviewers to take a look at this as well. Could you please add additional information on this issue regarding what were the alternate implementations considered in solving this problem?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org