You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org> on 2006/07/06 11:18:30 UTC

[jira] Commented: (TUSCANY-153) ChangeSummary on root data object not supported

    [ http://issues.apache.org/jira/browse/TUSCANY-153?page=comments#action_12419452 ] 

Kelvin Goodson commented on TUSCANY-153:
----------------------------------------

When I run XSD2JavaGenerator against the test.xsd in the supplied jar I get very different generated code from that found in the jar,  e.g. CustomerImpl's setID method in the jar is ...

  public void setID(int newID)
  {
    id = newID;
  }

and my generated code has ...

  public void setID(int newID)
  {
    int oldID = id;
    id = newID;
    boolean oldIDESet = idESet;
    idESet = true;
    if (eNotificationRequired())
      eNotify(new ENotificationImpl(this, Notification.SET, DasPackageImpl.CUSTOMER__ID, oldID, id, !oldIDESet));
  }


running the test against the new generated code gives ...

das.impl.OrderImpl@fa7e74 (ID: <unset>, Product: null, Quantity: 5, Customer_ID: <unset>)
das.impl.CustomerImpl@183f74d (ID: 5, lastName: null, address: null)
das.impl.OrderImpl@80f4cb (ID: 10, Product: null, Quantity: <unset>, Customer_ID: <unset>)
org.apache.tuscany.sdo.impl.DynamicDataObjectImpl@1a679b7 (eClass: org.apache.tuscany.sdo.impl.ClassImpl@4741d6 (name: DataGraphRoot) (instanceClassName: null) (abstract: false, interface: false))


> ChangeSummary on root data object not supported
> -----------------------------------------------
>
>          Key: TUSCANY-153
>          URL: http://issues.apache.org/jira/browse/TUSCANY-153
>      Project: Tuscany
>         Type: Bug

>   Components: Java SDO Implementation
>     Versions: Java-Mx
>     Reporter: Kevin Williams
>      Fix For: Java-Mx
>  Attachments: tuscany153.jar
>
> The RDB DAS intends to produce data graphs without using a DataGraph instance and this requires us to attach a change history to the root DataObject.  It seems that this capability is not yet implemented.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Re: [jira] Commented: (TUSCANY-153) ChangeSummary on root data object not supported

Posted by Frank Budinsky <fr...@ca.ibm.com>.
Brent,

The JavaDoc for the -noNotification generator option says it all:

 *     -noNotification
 *         This option eliminates all change notification overhead in the 
generated classes. Changes to
 *         DataObjects generated using this option cannot be recorded, and 
consequently the classes cannot
 *         be used with an SDO ChangeSummary or DataGraph.

You should definitely not be using it.

Thanks,
Frank.

"Brent Daniel" <br...@gmail.com> wrote on 07/06/2006 07:48:05 AM:

> Kelvin,
> 
>   It looks like the difference between your generated code and mine is
> that mine is being generated with the "noNotificationRequired" option.
> I'm not sure why our test cases started using this for generated
> classes, but it seems to work for all normal cases, but not for this
> one. Regardless, we should be able to make progress without this issue
> blocking us given that we can generate the models with notification
> turned on.
> 
> Thanks,
> Brent
> 
> 
> On 7/6/06, Kelvin Goodson (JIRA) <tu...@ws.apache.org> wrote:
> >    [ http://issues.apache.org/jira/browse/TUSCANY-153?
> page=comments#action_12419452 ]
> >
> > Kelvin Goodson commented on TUSCANY-153:
> > ----------------------------------------
> >
> > When I run XSD2JavaGenerator against the test.xsd in the supplied 
> jar I get very different generated code from that found in the jar, 
> e.g. CustomerImpl's setID method in the jar is ...
> >
> >  public void setID(int newID)
> >  {
> >    id = newID;
> >  }
> >
> > and my generated code has ...
> >
> >  public void setID(int newID)
> >  {
> >    int oldID = id;
> >    id = newID;
> >    boolean oldIDESet = idESet;
> >    idESet = true;
> >    if (eNotificationRequired())
> >      eNotify(new ENotificationImpl(this, Notification.SET, 
> DasPackageImpl.CUSTOMER__ID, oldID, id, !oldIDESet));
> >  }
> >
> >
> > running the test against the new generated code gives ...
> >
> > das.impl.OrderImpl@fa7e74 (ID: <unset>, Product: null, Quantity: 
> 5, Customer_ID: <unset>)
> > das.impl.CustomerImpl@183f74d (ID: 5, lastName: null, address: null)
> > das.impl.OrderImpl@80f4cb (ID: 10, Product: null, Quantity: 
> <unset>, Customer_ID: <unset>)
> > org.apache.tuscany.sdo.impl.DynamicDataObjectImpl@1a679b7 (eClass:
> org.apache.tuscany.sdo.impl.ClassImpl@4741d6 (name: DataGraphRoot) 
> (instanceClassName: null) (abstract: false, interface: false))
> >
> >
> > > ChangeSummary on root data object not supported
> > > -----------------------------------------------
> > >
> > >          Key: TUSCANY-153
> > >          URL: http://issues.apache.org/jira/browse/TUSCANY-153
> > >      Project: Tuscany
> > >         Type: Bug
> >
> > >   Components: Java SDO Implementation
> > >     Versions: Java-Mx
> > >     Reporter: Kevin Williams
> > >      Fix For: Java-Mx
> > >  Attachments: tuscany153.jar
> > >
> > > The RDB DAS intends to produce data graphs without using a 
> DataGraph instance and this requires us to attach a change history 
> to the root DataObject.  It seems that this capability is not yet 
implemented.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the 
administrators:
> >   http://issues.apache.org/jira/secure/Administrators.jspa
> > -
> > For more information on JIRA, see:
> >   http://www.atlassian.com/software/jira
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Re: [jira] Commented: (TUSCANY-153) ChangeSummary on root data object not supported

Posted by Brent Daniel <br...@gmail.com>.
Kelvin,

  It looks like the difference between your generated code and mine is
that mine is being generated with the "noNotificationRequired" option.
I'm not sure why our test cases started using this for generated
classes, but it seems to work for all normal cases, but not for this
one. Regardless, we should be able to make progress without this issue
blocking us given that we can generate the models with notification
turned on.

Thanks,
Brent


On 7/6/06, Kelvin Goodson (JIRA) <tu...@ws.apache.org> wrote:
>    [ http://issues.apache.org/jira/browse/TUSCANY-153?page=comments#action_12419452 ]
>
> Kelvin Goodson commented on TUSCANY-153:
> ----------------------------------------
>
> When I run XSD2JavaGenerator against the test.xsd in the supplied jar I get very different generated code from that found in the jar,  e.g. CustomerImpl's setID method in the jar is ...
>
>  public void setID(int newID)
>  {
>    id = newID;
>  }
>
> and my generated code has ...
>
>  public void setID(int newID)
>  {
>    int oldID = id;
>    id = newID;
>    boolean oldIDESet = idESet;
>    idESet = true;
>    if (eNotificationRequired())
>      eNotify(new ENotificationImpl(this, Notification.SET, DasPackageImpl.CUSTOMER__ID, oldID, id, !oldIDESet));
>  }
>
>
> running the test against the new generated code gives ...
>
> das.impl.OrderImpl@fa7e74 (ID: <unset>, Product: null, Quantity: 5, Customer_ID: <unset>)
> das.impl.CustomerImpl@183f74d (ID: 5, lastName: null, address: null)
> das.impl.OrderImpl@80f4cb (ID: 10, Product: null, Quantity: <unset>, Customer_ID: <unset>)
> org.apache.tuscany.sdo.impl.DynamicDataObjectImpl@1a679b7 (eClass: org.apache.tuscany.sdo.impl.ClassImpl@4741d6 (name: DataGraphRoot) (instanceClassName: null) (abstract: false, interface: false))
>
>
> > ChangeSummary on root data object not supported
> > -----------------------------------------------
> >
> >          Key: TUSCANY-153
> >          URL: http://issues.apache.org/jira/browse/TUSCANY-153
> >      Project: Tuscany
> >         Type: Bug
>
> >   Components: Java SDO Implementation
> >     Versions: Java-Mx
> >     Reporter: Kevin Williams
> >      Fix For: Java-Mx
> >  Attachments: tuscany153.jar
> >
> > The RDB DAS intends to produce data graphs without using a DataGraph instance and this requires us to attach a change history to the root DataObject.  It seems that this capability is not yet implemented.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>   http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>   http://www.atlassian.com/software/jira
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org