[GitHub] [cassandra] rtib commented on a diff in pull request #2253: CASSANDRA-18124 Make keystore_password nullable

["rtib (via GitHub)" <gi...@apache.org>]

rtib commented on code in PR #2253:
URL: https://github.com/apache/cassandra/pull/2253#discussion_r1158212667


##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -147,9 +151,9 @@ public EncryptionOptions()
         ssl_context_factory = new ParameterizedClass("org.apache.cassandra.security.DefaultSslContextFactory",
                                                      new HashMap<>());
         keystore = "conf/.keystore";
-        keystore_password = "cassandra";
+        keystore_password = null;
         truststore = "conf/.truststore";
-        truststore_password = "cassandra";
+        truststore_password = null;

Review Comment:
   While I understand the concern about changing a default value belongs to a major release, I'm not sure that the original issue should wait for 5.0. Any solution shipped with the next 4.1 release is considered better than postpone to 5.0.
   
   Would it possible to leave the default value `cassandra` in place while enabling it to be set null explicitly? IMO, that wouldn't conflict with SemVer policy and could be release with the next 4.1.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org