You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/10 15:30:47 UTC
[GitHub] [pulsar-manager] dianacle opened a new pull request #360: Issue 359: Upgrade BKVM to 3.0.0
dianacle opened a new pull request #360:
URL: https://github.com/apache/pulsar-manager/pull/360
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the `./gradlew build` checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tuteng merged pull request #360: Issue 359: Upgrade BKVM to 3.0.0
Posted by GitBox <gi...@apache.org>.
tuteng merged pull request #360:
URL: https://github.com/apache/pulsar-manager/pull/360
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] dianacle commented on a change in pull request #360: Issue 359: Upgrade BKVM to 3.0.0
Posted by GitBox <gi...@apache.org>.
dianacle commented on a change in pull request #360:
URL: https://github.com/apache/pulsar-manager/pull/360#discussion_r542253585
##########
File path: gradle.properties
##########
@@ -10,16 +10,16 @@ lombokVersion=1.18.10
pageHelperVersion=1.2.4
mockitoVersion=2.8.47
guavaVersion=21.0
-pulsarVersion=2.5.2
+pulsarVersion=2.7.0
swagger2Version=2.9.2
swaggeruiVersion=2.9.2
apiMockitoVersion=1.7.1
mockitoJunit4Version=1.7.1
gsonVersion=2.8.2
postgresqlVersion=42.2.5
-herddbVersion=0.19.0
+herddbVersion=0.22.0
brokerVersion=2.4.1
Review comment:
You're right. I removed the variable brokerVersion and replaced it with pulsarVersion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] eolivelli commented on a change in pull request #360: Issue 359: Upgrade BKVM to 3.0.0
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #360:
URL: https://github.com/apache/pulsar-manager/pull/360#discussion_r541914719
##########
File path: gradle.properties
##########
@@ -10,16 +10,16 @@ lombokVersion=1.18.10
pageHelperVersion=1.2.4
mockitoVersion=2.8.47
guavaVersion=21.0
-pulsarVersion=2.5.2
+pulsarVersion=2.7.0
swagger2Version=2.9.2
swaggeruiVersion=2.9.2
apiMockitoVersion=1.7.1
mockitoJunit4Version=1.7.1
gsonVersion=2.8.2
postgresqlVersion=42.2.5
-herddbVersion=0.19.0
+herddbVersion=0.22.0
brokerVersion=2.4.1
Review comment:
can you please check this variable ?
it looks like it is another variable to refer to Pulsar.
I suggest to remove this variable and replace the reference to it with a reference to pulsarVersion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org