[GitHub] [hudi] danny0405 commented on a diff in pull request #7955: [HUDI-5649] Unify all the loggers to slf4j

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #7955:
URL: https://github.com/apache/hudi/pull/7955#discussion_r1153994131


##########
packaging/hudi-cli-bundle/pom.xml:
##########
@@ -298,5 +299,15 @@
       <artifactId>log4j-core</artifactId>
       <scope>compile</scope>
     </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>
+      <scope>compile</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>jul-to-slf4j</artifactId>

Review Comment:
   Yes, `timeline server and metaserver` already includes the slf4j jar in current code base, there is no need to change.
   for `kafka-connect`, similar with other engines like Spark and Flink, we should not include the slf4j, like it does not incude the log4j too before, the kafka should suppliy the logger jar in the classpath.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org