You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Tim Williams (JIRA)" <ji...@apache.org> on 2005/07/08 12:49:14 UTC
[jira] Created: (FOR-570) head broken after locationmap merge
head broken after locationmap merge
-----------------------------------
Key: FOR-570
URL: http://issues.apache.org/jira/browse/FOR-570
Project: Forrest
Type: Bug
Components: Core operations
Versions: 0.8-dev
Reporter: Tim Williams
Attachments: broken-head.patch
LM component in forrest.xconf wasn't added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (FOR-570) head broken after locationmap merge
Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-570?page=all ]
Ross Gardler reassigned FOR-570:
--------------------------------
Assign To: Ross Gardler
> head broken after locationmap merge
> -----------------------------------
>
> Key: FOR-570
> URL: http://issues.apache.org/jira/browse/FOR-570
> Project: Forrest
> Type: Bug
> Components: Core operations
> Versions: 0.8-dev
> Reporter: Tim Williams
> Assignee: Ross Gardler
> Attachments: broken-head-2.patch, broken-head-3.patch, broken-head.patch
>
> LM component in forrest.xconf wasn't added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-570) head broken after locationmap merge
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-570?page=all ]
Tim Williams updated FOR-570:
-----------------------------
Attachment: broken-head-2.patch
I don't think there's much more to it. It needs the lm scheme added, input module, and... the reference to the actual locationmap. Here's a patch to do that. I've confirmed that simple location resolutions work (e.g. site.xml, tabs.xml) I haven't checked resources and all. I don't mean to duplicate you work but since I felt a responsibility since I created over-simplified first patch. Both now need applied.
> head broken after locationmap merge
> -----------------------------------
>
> Key: FOR-570
> URL: http://issues.apache.org/jira/browse/FOR-570
> Project: Forrest
> Type: Bug
> Components: Core operations
> Versions: 0.8-dev
> Reporter: Tim Williams
> Attachments: broken-head-2.patch, broken-head.patch
>
> LM component in forrest.xconf wasn't added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-570) head broken after locationmap merge
Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-570?page=comments#action_12315286 ]
Ross Gardler commented on FOR-570:
----------------------------------
Thanks Tim, I'm looking at the problem now. There is actually much more to it than just the changes to forrest.xconf. I'll apply this patch when I've worked out exactly what has gone wrong.
> head broken after locationmap merge
> -----------------------------------
>
> Key: FOR-570
> URL: http://issues.apache.org/jira/browse/FOR-570
> Project: Forrest
> Type: Bug
> Components: Core operations
> Versions: 0.8-dev
> Reporter: Tim Williams
> Attachments: broken-head.patch
>
> LM component in forrest.xconf wasn't added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-570) head broken after locationmap merge
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-570?page=all ]
Tim Williams updated FOR-570:
-----------------------------
Attachment: broken-head.patch
The issue was reported here:
http://marc.theaimsgroup.com/?t=112081051100002&r=1&w=2
I don't have time to do complete LM functional testing but this patch gets us back up and running.
> head broken after locationmap merge
> -----------------------------------
>
> Key: FOR-570
> URL: http://issues.apache.org/jira/browse/FOR-570
> Project: Forrest
> Type: Bug
> Components: Core operations
> Versions: 0.8-dev
> Reporter: Tim Williams
> Attachments: broken-head.patch
>
> LM component in forrest.xconf wasn't added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Closed: (FOR-570) head broken after locationmap merge
Posted by Thorsten Scherler <th...@apache.org>.
On Fri, 2005-07-08 at 14:23 +0100, Ross Gardler wrote:
> Thorsten Scherler wrote:
> > Thanks very much for stepping in and finish the merge.
>
> We all chip in - thanks to Tim as well.
>
> Ross
Yes right, thanks to tim as well. :)
salu2
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
Re: [jira] Closed: (FOR-570) head broken after locationmap merge
Posted by Ross Gardler <rg...@apache.org>.
Thorsten Scherler wrote:
> Thanks very much for stepping in and finish the merge.
We all chip in - thanks to Tim as well.
Ross
Re: [jira] Closed: (FOR-570) head broken after locationmap merge
Posted by Thorsten Scherler <th...@apache.org>.
Thanks very much for stepping in and finish the merge.
Sorry again.
salu2
On Fri, 2005-07-08 at 15:11 +0200, Ross Gardler (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/FOR-570?page=all ]
>
> Ross Gardler closed FOR-570:
> ----------------------------
>
> Resolution: Fixed
>
> My test sites and ./build.sh test now pass
>
> > head broken after locationmap merge
> > -----------------------------------
> >
> > Key: FOR-570
> > URL: http://issues.apache.org/jira/browse/FOR-570
> > Project: Forrest
> > Type: Bug
> > Components: Core operations
> > Versions: 0.8-dev
> > Reporter: Tim Williams
> > Assignee: Ross Gardler
> > Attachments: broken-head-2.patch, broken-head-3.patch, broken-head.patch
> >
> > LM component in forrest.xconf wasn't added.
>
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
[jira] Closed: (FOR-570) head broken after locationmap merge
Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-570?page=all ]
Ross Gardler closed FOR-570:
----------------------------
Resolution: Fixed
My test sites and ./build.sh test now pass
> head broken after locationmap merge
> -----------------------------------
>
> Key: FOR-570
> URL: http://issues.apache.org/jira/browse/FOR-570
> Project: Forrest
> Type: Bug
> Components: Core operations
> Versions: 0.8-dev
> Reporter: Tim Williams
> Assignee: Ross Gardler
> Attachments: broken-head-2.patch, broken-head-3.patch, broken-head.patch
>
> LM component in forrest.xconf wasn't added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-570) head broken after locationmap merge
Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-570?page=comments#action_12315297 ]
Ross Gardler commented on FOR-570:
----------------------------------
Still more to it than that, there are a number of files that have not been copied across. You have most of them here. I'm working on it, in fact I think I have it sorted now. Just doing the testing.
Incdentally, your patches do not give the correct paths to the files, for example broken-head-3.patch just identifies the file as locationmap.xml, if someone doesn't know where this belongs they can't apply the patch. I think this is caused by creating the diff from within the directory that the file appears in rather than from the root of the project.
> head broken after locationmap merge
> -----------------------------------
>
> Key: FOR-570
> URL: http://issues.apache.org/jira/browse/FOR-570
> Project: Forrest
> Type: Bug
> Components: Core operations
> Versions: 0.8-dev
> Reporter: Tim Williams
> Attachments: broken-head-2.patch, broken-head-3.patch, broken-head.patch
>
> LM component in forrest.xconf wasn't added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-570) head broken after locationmap merge
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-570?page=all ]
Tim Williams updated FOR-570:
-----------------------------
Attachment: broken-head-3.patch
Assuming we still want to give a sample locationmap, we also need this on fresh-site.
> head broken after locationmap merge
> -----------------------------------
>
> Key: FOR-570
> URL: http://issues.apache.org/jira/browse/FOR-570
> Project: Forrest
> Type: Bug
> Components: Core operations
> Versions: 0.8-dev
> Reporter: Tim Williams
> Attachments: broken-head-2.patch, broken-head-3.patch, broken-head.patch
>
> LM component in forrest.xconf wasn't added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira