[jira] [Commented] (AIRFLOW-5318) BigQuery - Option to specify location when creating an empty dataset

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916651#comment-16916651 ] 

ASF GitHub Bot commented on AIRFLOW-5318:
-----------------------------------------

mohannadbanayosi commented on pull request #5923: AIRFLOW-5318 Option to specify location of the new BQ dataset
URL: https://github.com/apache/airflow/pull/5923
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-5318) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5318
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   The extra `str` argument gives the option to easily specify the location where the user wants the new BQ dataset to reside. The location will be `US` if nothing is provided.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> BigQuery - Option to specify location when creating an empty dataset
> --------------------------------------------------------------------
>
>                 Key: AIRFLOW-5318
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5318
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib, gcp
>    Affects Versions: 1.10.3
>            Reporter: Mohannad Albanayosy
>            Assignee: Mohannad Albanayosy
>            Priority: Minor
>
> h2. Problem
> To specify the location for a new empty dataset, the user has to add it to the _dataset_reference_.
> h2. Proposed improvement
> Add _location_ as an extra argument to the BigQueryCreateEmptyDatasetOperator to specify the location of the new dataset.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)