You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/08 07:58:12 UTC

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #308: [FLINK-29292] Make result of MergeFunction generic

JingsongLi commented on code in PR #308:
URL: https://github.com/apache/flink-table-store/pull/308#discussion_r990607817


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/PartialUpdateMergeFunction.java:
##########
@@ -63,12 +67,19 @@ public void add(KeyValue kv) {
 
     @Override
     @Nullable
-    public RowData getValue() {
-        return row;
+    public KeyValue getResult() {
+        if (latestKv == null) {
+            return null;

Review Comment:
   throw exception here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org