[GitHub] [rocketmq] dongeforever commented on a change in pull request #1149: [issue##1147]Broker will report Exception if open the aclEnable and enableDLegerCommitLog flag at the same time.

[GitBox <gi...@apache.org>]

dongeforever commented on a change in pull request #1149: [issue##1147]Broker will report Exception if open the aclEnable and enableDLegerCommitLog flag at the same time.
URL: https://github.com/apache/rocketmq/pull/1149#discussion_r273949666
 
 

 ##########
 File path: acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessValidator.java
 ##########
 @@ -54,14 +54,16 @@ public AccessResource parse(RemotingCommand request, String remoteAddr) {
         }
 
         if (request.getExtFields() == null) {
-            throw new AclException("request's extFields value is null");
+            //If request's extFields is null,then return accessResource directly(users can use whiteAddress pattern)
+            return accessResource;
         }
-        
+
         accessResource.setRequestCode(request.getCode());
         accessResource.setAccessKey(request.getExtFields().get(SessionCredentials.ACCESS_KEY));
 
 Review comment:
   setRequestCode at first

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services