You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by sr...@apache.org on 2015/11/02 23:19:11 UTC
[04/17] storm git commit: rename test to value only test with topic
rename test to value only test with topic
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/fe7de58f
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/fe7de58f
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/fe7de58f
Branch: refs/heads/master
Commit: fe7de58f09a1a8a886d218c837eb185708264e62
Parents: 602cbba
Author: Sumit Chawla <su...@gmail.com>
Authored: Wed May 27 14:42:06 2015 -0700
Committer: Sumit Chawla <su...@gmail.com>
Committed: Wed May 27 14:42:06 2015 -0700
----------------------------------------------------------------------
.../src/test/storm/kafka/KafkaUtilsTest.java | 27 +++++++++-----------
1 file changed, 12 insertions(+), 15 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/fe7de58f/external/storm-kafka/src/test/storm/kafka/KafkaUtilsTest.java
----------------------------------------------------------------------
diff --git a/external/storm-kafka/src/test/storm/kafka/KafkaUtilsTest.java b/external/storm-kafka/src/test/storm/kafka/KafkaUtilsTest.java
index 7fe7d27..e9fff6b 100644
--- a/external/storm-kafka/src/test/storm/kafka/KafkaUtilsTest.java
+++ b/external/storm-kafka/src/test/storm/kafka/KafkaUtilsTest.java
@@ -142,7 +142,7 @@ public class KafkaUtilsTest {
createTopicAndSendMessage(key, value);
ByteBufferMessageSet messageAndOffsets = getLastMessage();
for (MessageAndOffset msg : messageAndOffsets) {
- Iterable<List<Object>> lists = KafkaUtils.generateTuples(config, msg.message(), null);
+ Iterable<List<Object>> lists = KafkaUtils.generateTuples(config, msg.message(), config.topic);
assertEquals(ImmutableMap.of(key, value), lists.iterator().next().get(0));
}
}
@@ -154,32 +154,29 @@ public class KafkaUtilsTest {
}
@Test
- public void generateTuplesWithValueSchemeAndKeyValueMessage() {
- config.scheme = new SchemeAsMultiScheme(new StringScheme());
+ public void generateTuplesWithValueAndStringMultiSchemeWithTopic() {
+ config.scheme = new StringMultiSchemeWithTopic();
String value = "value";
- String key = "key";
- createTopicAndSendMessage(key, value);
+ createTopicAndSendMessage(value);
ByteBufferMessageSet messageAndOffsets = getLastMessage();
for (MessageAndOffset msg : messageAndOffsets) {
- Iterable<List<Object>> lists = KafkaUtils.generateTuples(config, msg.message(), null);
- assertEquals(value, lists.iterator().next().get(0));
-
+ Iterable<List<Object>> lists = KafkaUtils.generateTuples(config, msg.message(), config.topic);
+ List<Object> list = lists.iterator().next();
+ assertEquals(value, list.get(0));
+ assertEquals(config.topic, list.get(1));
}
}
-
@Test
- public void generateTuplesWithStringMultSchemeWithTopic() {
- config.scheme = new StringMultiSchemeWithTopic();
+ public void generateTuplesWithValueSchemeAndKeyValueMessage() {
+ config.scheme = new SchemeAsMultiScheme(new StringScheme());
String value = "value";
String key = "key";
createTopicAndSendMessage(key, value);
ByteBufferMessageSet messageAndOffsets = getLastMessage();
for (MessageAndOffset msg : messageAndOffsets) {
Iterable<List<Object>> lists = KafkaUtils.generateTuples(config, msg.message(), config.topic);
- List<Object> list = lists.iterator().next();
- assertEquals(value, list.get(0));
- assertEquals(config.topic, list.get(1));
+ assertEquals(value, lists.iterator().next().get(0));
}
}
@@ -193,7 +190,7 @@ public class KafkaUtilsTest {
createTopicAndSendMessage(null, value);
ByteBufferMessageSet messageAndOffsets = getLastMessage();
for (MessageAndOffset msg : messageAndOffsets) {
- Iterable<List<Object>> lists = KafkaUtils.generateTuples(config, msg.message(), null);
+ Iterable<List<Object>> lists = KafkaUtils.generateTuples(config, msg.message(), config.topic);
assertEquals(value, lists.iterator().next().get(0));
}
}