You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/30 15:47:42 UTC
[GitHub] [airflow] turbaszek opened a new pull request #9074: Remove Travis CI badge from README
turbaszek opened a new pull request #9074:
URL: https://github.com/apache/airflow/pull/9074
Since we abandoned Travis there's no reason to keep this badge. I've also split badges to two lines for a better look.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #9074: Remove Travis CI badge from README
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #9074:
URL: https://github.com/apache/airflow/pull/9074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9074: Remove Travis CI badge from README
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9074:
URL: https://github.com/apache/airflow/pull/9074#discussion_r432865766
##########
File path: README.md
##########
@@ -20,9 +20,9 @@
[](https://badge.fury.io/py/apache-airflow)
-[](https://travis-ci.org/apache/airflow)
[](https://codecov.io/github/apache/airflow?branch=master)
[](https://airflow.readthedocs.io/en/latest/?badge=latest)
+
[](http://www.apache.org/licenses/LICENSE-2.0.txt)
[](https://pypi.org/project/apache-airflow/)
[](https://twitter.com/ApacheAirflow)
Review comment:
I can delete this change ¯\_(ツ)_/¯
My thinking was:
- blue badges in one line
- join slack badge is placed in the middle giving better call to action imho
- badges looks like organized not just like put in "let it be" way...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9074: Remove Travis CI badge from README
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9074:
URL: https://github.com/apache/airflow/pull/9074#discussion_r432865650
##########
File path: README.md
##########
@@ -20,9 +20,9 @@
[](https://badge.fury.io/py/apache-airflow)
-[](https://travis-ci.org/apache/airflow)
[](https://codecov.io/github/apache/airflow?branch=master)
[](https://airflow.readthedocs.io/en/latest/?badge=latest)
+
[](http://www.apache.org/licenses/LICENSE-2.0.txt)
[](https://pypi.org/project/apache-airflow/)
[](https://twitter.com/ApacheAirflow)
Review comment:
<img width="1250" alt="Screenshot 2020-05-30 at 17 53 23" src="https://user-images.githubusercontent.com/12058428/83332967-7f26c080-a29e-11ea-8050-442450d13b26.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9074: Remove Travis CI badge from README
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9074:
URL: https://github.com/apache/airflow/pull/9074#discussion_r432865899
##########
File path: README.md
##########
@@ -20,9 +20,9 @@
[](https://badge.fury.io/py/apache-airflow)
-[](https://travis-ci.org/apache/airflow)
[](https://codecov.io/github/apache/airflow?branch=master)
[](https://airflow.readthedocs.io/en/latest/?badge=latest)
+
[](http://www.apache.org/licenses/LICENSE-2.0.txt)
[](https://pypi.org/project/apache-airflow/)
[](https://twitter.com/ApacheAirflow)
Review comment:
I am ok with your proposition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9074: Remove Travis CI badge from README
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9074:
URL: https://github.com/apache/airflow/pull/9074#discussion_r432865766
##########
File path: README.md
##########
@@ -20,9 +20,9 @@
[](https://badge.fury.io/py/apache-airflow)
-[](https://travis-ci.org/apache/airflow)
[](https://codecov.io/github/apache/airflow?branch=master)
[](https://airflow.readthedocs.io/en/latest/?badge=latest)
+
[](http://www.apache.org/licenses/LICENSE-2.0.txt)
[](https://pypi.org/project/apache-airflow/)
[](https://twitter.com/ApacheAirflow)
Review comment:
My thinking was:
- blue badges in one line
- join slack badge is placed in the middle giving better call to action imho
- badges looks like organized not just like put in "let it be" way...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9074: Remove Travis CI badge from README
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9074:
URL: https://github.com/apache/airflow/pull/9074#discussion_r432865389
##########
File path: README.md
##########
@@ -20,9 +20,9 @@
[](https://badge.fury.io/py/apache-airflow)
-[](https://travis-ci.org/apache/airflow)
[](https://codecov.io/github/apache/airflow?branch=master)
[](https://airflow.readthedocs.io/en/latest/?badge=latest)
+
[](http://www.apache.org/licenses/LICENSE-2.0.txt)
[](https://pypi.org/project/apache-airflow/)
[](https://twitter.com/ApacheAirflow)
Review comment:
What do you think to break here? Twitter has a different button style.
##########
File path: README.md
##########
@@ -20,9 +20,9 @@
[](https://badge.fury.io/py/apache-airflow)
-[](https://travis-ci.org/apache/airflow)
[](https://codecov.io/github/apache/airflow?branch=master)
[](https://airflow.readthedocs.io/en/latest/?badge=latest)
+
[](http://www.apache.org/licenses/LICENSE-2.0.txt)
[](https://pypi.org/project/apache-airflow/)
[](https://twitter.com/ApacheAirflow)
Review comment:
What do you think to break here? Twitter has a different badge style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org