You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/10/27 14:24:04 UTC
[I] [camel-main] Foundation:type-converter:tests - refactor the quick as a result of CAMEL-20051 [camel-quarkus]
JiriOndrusek opened a new issue, #5467:
URL: https://github.com/apache/camel-quarkus/issues/5467
### Bug description
Change https://github.com/apache/camel/commit/7c104aaaff93a930cb2b26bb85ae848d9e8d2af3 brought caching of the fallback converters.
Our tests in foundation - ttype-coverter uses fallback converters for several test methods with different converters for the same class in each method.
1 - #1 method caches converter#1 for type A
2 - #2 method converts type A with converter#2, but gets converter#1, which fails the assertion.
Quick fix introduces QuarkusTestProfiles, to force camel context to be restarted is part of `camel-main`.
Better fix would be the refactor of the methods to use different types for fallback methods, which would avoid the caching issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [camel-main] Foundation:type-converter:tests - refactor the quick fix which is result of CAMEL-20051 [camel-quarkus]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on issue #5467:
URL: https://github.com/apache/camel-quarkus/issues/5467#issuecomment-1783085809
@JiriOndrusek Maybe we should add a method in core to cleanup the cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [camel-main] Foundation:type-converter:tests - refactor the quick fix which is result of CAMEL-20051 [camel-quarkus]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on issue #5467:
URL: https://github.com/apache/camel-quarkus/issues/5467#issuecomment-1784789105
> Hi @orpiske, I was thinking about it, but I can not decide whether we really need it. (clean method would be used only in special cases, probably never during runtime) On the other hand, it can be nice to have it. If it makes sense for you to add such method, we can do that, it would be definitely helpful. But it is not necessary.
Yeah. That's a risk one to have, as users may try to clean it up and get into trouble because of that. But ... we can try to design it in a way to makes it useful only during testing.
In any case: just let me know what you decide and we can discuss it further if you believe that is the right way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [camel-main] Foundation:type-converter:tests - refactor the quick fix which is result of CAMEL-20051 [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on issue #5467:
URL: https://github.com/apache/camel-quarkus/issues/5467#issuecomment-1784620412
Hi @orpiske, I was thinking about it, but I can not decide whether we really need it. (clean method would be used only in special cases, probably never during runtime) On the other hand, it can be nice to have it. If it makes sense for you to add such method, we can do that, it would be definitely helpful. But it is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org