[GitHub] [accumulo] cjmctague commented on a change in pull request #1018: Fix #976 - Expand overly broad Exceptions in Accumulo-core

[GitBox <gi...@apache.org>]

cjmctague commented on a change in pull request #1018: Fix #976 - Expand overly broad Exceptions in Accumulo-core
URL: https://github.com/apache/accumulo/pull/1018#discussion_r264247514
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java
 ##########
 @@ -406,7 +406,7 @@ public void close() {
       if (this.blockCacheManager != null) {
         this.blockCacheManager.stop();
       }
-    } catch (Exception e1) {
+    } catch (RuntimeException e1) {
 
 Review comment:
   `this.blockCacheManager.stop();` has the possibility to throw an `UnsupportedOperationException` so I can catch/throw that here to narrow it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services