[jira] [Commented] (FLINK-4458) Remove ForkableFlinkMiniCluster

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455509#comment-15455509 ] 

ASF GitHub Bot commented on FLINK-4458:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2450#discussion_r77180730
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala ---
    @@ -69,7 +69,7 @@ abstract class FlinkMiniCluster(
         ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
         InetAddress.getByName("localhost").getHostAddress())
     
    -  val configuration = generateConfiguration(userConfiguration)
    +  protected val _configuration = generateConfiguration(userConfiguration)
    --- End diff --
    
    Why the underscore here?


> Remove ForkableFlinkMiniCluster
> -------------------------------
>
>                 Key: FLINK-4458
>                 URL: https://issues.apache.org/jira/browse/FLINK-4458
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> After addressing FLINK-4424 we should be able to get rid of the {{ForkableFlinkMiniCluster}} since we no longer have to pre-determine a port in Flink. Thus, by setting the ports to {{0}} and letting the OS choose a free port, there should no longer be conflicting port requests. Consequently, the {{ForkableFlinkMiniCluster}} will become obsolete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)