You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/04 03:40:46 UTC

[GitHub] [skywalking-data-collect-protocol] arugal commented on a change in pull request #18: Change BrowserPerfData#logs field

arugal commented on a change in pull request #18: Change BrowserPerfData#logs field
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r374460482
 
 

 ##########
 File path: browser/BrowserPerf.proto
 ##########
 @@ -41,7 +41,7 @@ message BrowserPerfData {
     // Page path in the browser, mostly it is URI, without parameter
     string pagePath = 5;
     int32 pagePathId = 6;
-    repeated BrowserErrorLog logs = 7;
+    BrowserErrorLog errorLog = 7;
 
 Review comment:
   I'll change the proto.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services