You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gao8658 <gi...@git.apache.org> on 2014/06/19 01:29:16 UTC
[GitHub] spark pull request: Add ZLIBCompressionCodec code
GitHub user gao8658 opened a pull request:
https://github.com/apache/spark/pull/1121
Add ZLIBCompressionCodec code
I want to add a new API,ZLIBCompressionCodec,support ZLIB compress
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gao8658/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1121
----
commit b87c1c479e654aa3eb034dc80370553739aaf51f
Author: Yanjie Gao <ga...@163.com>
Date: 2014-06-18T23:29:03Z
Add ZLIBCompressionCodec code
I want to add a new API,ZLIBCompressionCodec,support ZLIB compress
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Add ZLIBCompressionCodec code
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1121#issuecomment-46507494
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2237][CORE]Add ZLIBCompressionCodec cod...
Posted by YanjieGao <gi...@git.apache.org>.
Github user YanjieGao commented on the pull request:
https://github.com/apache/spark/pull/1121#issuecomment-47869431
Hi all,I have resolve the conflict i don't know if this pr has value to be merged? Thanks a lot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2237][CORE]Add ZLIBCompressionCodec cod...
Posted by YanjieGao <gi...@git.apache.org>.
Github user YanjieGao closed the pull request at:
https://github.com/apache/spark/pull/1121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2237][CORE]Add ZLIBCompressionCodec cod...
Posted by YanjieGao <gi...@git.apache.org>.
Github user YanjieGao commented on the pull request:
https://github.com/apache/spark/pull/1121#issuecomment-54283956
Ok,i thinks so ,may be some small third-party lib may cause uncertain problem , I will close this PR. If have some mature solution , i will send PR and make a contribution. Best regards!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2237][CORE]Add ZLIBCompressionCodec cod...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1121#issuecomment-53973370
@YanjieGao do you see a major tradeoff in compressed size and speed with this codec over our current ones?
Also, I'm not sure your patch will compile as written. There's no Maven dependency on this ZLib library and there seem to be two classes called CompressionSuite. I'm also way to add something that depends on this small third-party library -- would be better to use Java's built-in GzipOutputStream.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org