You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "tiltwind (via GitHub)" <gi...@apache.org> on 2023/04/06 05:55:43 UTC
[GitHub] [dubbo-go-hessian2] tiltwind opened a new pull request, #357: fix issue 356 that ref to wrong type of map for nil value
tiltwind opened a new pull request, #357:
URL: https://github.com/apache/dubbo-go-hessian2/pull/357
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
fix issue #356 that ref to wrong type of map for nil value
**Which issue(s) this PR fixes**:
Fixes #356
**Special notes for your reviewer**:
None
**Does this PR introduce a user-facing change?**:
```release-note
fix issue #356 that ref to wrong type of map for nil value
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo merged pull request #357: fix issue 356 that ref to wrong type of map for nil value
Posted by "wongoo (via GitHub)" <gi...@apache.org>.
wongoo merged PR #357:
URL: https://github.com/apache/dubbo-go-hessian2/pull/357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter commented on pull request #357: fix issue 356 that ref to wrong type of map for nil value
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #357:
URL: https://github.com/apache/dubbo-go-hessian2/pull/357#issuecomment-1498542760
## [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/357?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#357](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/357?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (96e1b87) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/76ae75b37ae4fc6bf213c664fe95cea40fe72514?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (76ae75b) will **decrease** coverage by `0.03%`.
> The diff coverage is `90.00%`.
> :exclamation: Current head 96e1b87 differs from pull request most recent head 28977db. Consider uploading reports for the commit 28977db to get more accurate results
```diff
@@ Coverage Diff @@
## master #357 +/- ##
==========================================
- Coverage 72.18% 72.16% -0.03%
==========================================
Files 27 27
Lines 3128 3129 +1
==========================================
Hits 2258 2258
- Misses 633 634 +1
Partials 237 237
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [ref.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVmLmdv) | `83.11% <88.88%> (-1.10%)` | :arrow_down: |
| [map.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFwLmdv) | `59.58% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org