You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/04/21 10:35:48 UTC
[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1447: [CELEBORN-546][FLINK] [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId
RexXiong opened a new pull request, #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447
…pId, attemptId) for generating partitionId
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId
### Why are the changes needed?
encode(mapId, attemptId) will cause attemptId is limit to 255
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
UT & TPCDS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447#discussion_r1173757008
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -957,22 +956,13 @@ class PushDataHandler extends BaseMessageHandler with Logging {
callback: RpcResponseCallback,
wrappedCallback: RpcResponseCallback): Boolean = {
Review Comment:
wrappedCallback is not used. BTW, ```locationIsNull```, ```handleRpcRequestCore``` are only for MapPartition, I think better to refactor in the future.
##########
client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleMaster.java:
##########
@@ -238,18 +240,19 @@ public void close() throws Exception {
ThreadUtils.shutdownExecutors(10, executor);
}
- private ShuffleTask encodeExternalShuffleTask(
+ private ShuffleResourceDescriptor genShuffleResourceDescriptor(
Review Comment:
Will this method be called multiple times for the same (shuffleId, mapId, attemptId) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447#discussion_r1173848822
##########
client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleMaster.java:
##########
@@ -238,18 +240,19 @@ public void close() throws Exception {
ThreadUtils.shutdownExecutors(10, executor);
}
- private ShuffleTask encodeExternalShuffleTask(
+ private ShuffleResourceDescriptor genShuffleResourceDescriptor(
Review Comment:
No, same like attemptId, so i remove mapattemptId->attemptIdIndex map as same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447#discussion_r1174354759
##########
common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java:
##########
@@ -286,13 +285,9 @@ public String toString() {
peerAddr = peer.hostAndPorts();
}
return "PartitionLocation["
- + "\n id(rawId-attemptId)-epoch:"
+ + "\n id-epoch:"
Review Comment:
It's partial right, as the `<int> mapId `also comes from `LifecycleManager`. Only `LifecycleManager` has the knowledge which partition belongs to the actual resultPartition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447#discussion_r1174335448
##########
client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleDescriptor.java:
##########
@@ -58,6 +58,10 @@ public JobID getJobId() {
return jobId;
}
+ public String getShuffleId() {
Review Comment:
This method is not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447#issuecomment-1517722581
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1447?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1447](https://codecov.io/gh/apache/incubator-celeborn/pull/1447?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bcbc11) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/181c1bfcd6a64236f634d5cf508610b3b5d1274c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (181c1bf) will **decrease** coverage by `0.24%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1447 +/- ##
==========================================
- Coverage 45.01% 44.77% -0.24%
==========================================
Files 156 155 -1
Lines 9596 9586 -10
Branches 956 955 -1
==========================================
- Hits 4319 4291 -28
- Misses 4996 5011 +15
- Partials 281 284 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/celeborn/common/protocol/PartitionLocation.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vcHJvdG9jb2wvUGFydGl0aW9uTG9jYXRpb24uamF2YQ==) | `69.57% <ø> (-1.26%)` | :arrow_down: |
... and [3 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1447/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId
Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on code in PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447#discussion_r1173674937
##########
common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java:
##########
@@ -286,13 +285,9 @@ public String toString() {
peerAddr = peer.hostAndPorts();
}
return "PartitionLocation["
- + "\n id(rawId-attemptId)-epoch:"
+ + "\n id-epoch:"
Review Comment:
if we want to look at shufflewring filename of one map task, it's not directly to build the relation between filename ( id + "-" + epoch + "-" + mode.mode) and the mapid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447#discussion_r1173869206
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -957,22 +956,13 @@ class PushDataHandler extends BaseMessageHandler with Logging {
callback: RpcResponseCallback,
wrappedCallback: RpcResponseCallback): Boolean = {
Review Comment:
> wrappedCallback is not used. BTW, `locationIsNull`, `handleRpcRequestCore` are only for MapPartition, I think better to refactor in the future.
Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org