[GitHub] [spark] BryanCutler commented on a change in pull request #28915: [SPARK-32080][SPARK-31998][SQL] Simplify ArrowColumnVector ListArray accessor

[GitBox <gi...@apache.org>]

BryanCutler commented on a change in pull request #28915:
URL: https://github.com/apache/spark/pull/28915#discussion_r445059227



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
##########
@@ -458,10 +457,8 @@ final boolean isNullAt(int rowId) {
 
     @Override
     final ColumnarArray getArray(int rowId) {
-      ArrowBuf offsets = accessor.getOffsetBuffer();
-      int index = rowId * ListVector.OFFSET_WIDTH;
-      int start = offsets.getInt(index);
-      int end = offsets.getInt(index + ListVector.OFFSET_WIDTH);
+      int start = accessor.getElementStartIndex(rowId);

Review comment:
       Thanks @viirya , I wasn't aware SPARK-31998 was made, but yes that was the motivation for this fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org