[GitHub] [incubator-nuttx] normanr commented on a change in pull request #5150: net/misc: add support for CONFIG_NET_ALLOC_CONNS

[GitBox <gi...@apache.org>]

normanr commented on a change in pull request #5150:
URL: https://github.com/apache/incubator-nuttx/pull/5150#discussion_r785571432



##########
File path: net/icmp/icmp_conn.c
##########
@@ -109,13 +116,23 @@ FAR struct icmp_conn_s *icmp_alloc(void)
   ret = net_lockedwait(&g_free_sem);
   if (ret >= 0)
     {
+#ifdef CONFIG_NET_ALLOC_CONNS
+      if (dq_peek(&g_free_icmp_connections) == NULL)
+        {
+          conn = kmm_zalloc(sizeof(*conn) * CONFIG_NET_ICMP_NCONNS);
+          if (conn != NULL)
+            {
+              for (ret = 0; ret < CONFIG_NET_ICMP_NCONNS; ret++)
+                {
+                  dq_addlast(&conn[ret].node, &g_free_retcmp_connectretons);

Review comment:
       icmp/icmp_conn.c:127:48: error: `g_free_retcmp_connectretons` undeclared (first use in this function); did you mean `g_free_icmp_connections`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org