You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/06 17:06:34 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #11173: fix(viz): downgrade exception for missing datasource
villebro opened a new pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173
### SUMMARY
`viz.py` raises an `Exception` if a viz is referencing a datasource that doesn't exist. As this indicates corrupted viz metadata (usually a datasource has been deleted), this constitutes a `QueryObjectValidationError`, which is an expected exception type for invalid viz requests.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11173: fix(viz): downgrade exception for missing datasource
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704425205
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d7b8057556e1f6dfe02dc312f22146b5340f556?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
=======================================
Coverage 61.69% 61.70%
=======================================
Files 828 828
Lines 39114 39116 +2
Branches 3688 3688
=======================================
+ Hits 24133 24137 +4
+ Misses 14800 14798 -2
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.30% <ø> (ø)` | |
| #python | `61.34% <100.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.26% <0.00%> (-0.04%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `50.76% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.07% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [3d7b805...d97f797](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **increase** coverage by `0.61%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
+ Coverage 61.71% 62.33% +0.61%
==========================================
Files 828 437 -391
Lines 39112 14628 -24484
Branches 3692 3693 +1
==========================================
- Hits 24138 9118 -15020
+ Misses 14793 5329 -9464
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.33% <ø> (ø)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | | |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | | |
| [superset/examples/multi\_line.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlfbGluZS5weQ==) | | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | | |
| [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | | |
| [...versions/743a117f0d98\_add\_slack\_to\_the\_schedule.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83NDNhMTE3ZjBkOThfYWRkX3NsYWNrX3RvX3RoZV9zY2hlZHVsZS5weQ==) | | |
| [superset/db\_engine\_specs/pinot.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bpbm90LnB5) | | |
| [.../migrations/versions/2fcdcb35e487\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yZmNkY2IzNWU0ODdfc2F2ZWRfcXVlcmllcy5weQ==) | | |
| [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | | |
| ... and [379 more](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...0a9ea88](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #11173: fix(viz): downgrade exception for missing datasource
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704425205
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3d7b8057556e1f6dfe02dc312f22146b5340f556?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
=======================================
Coverage 61.69% 61.70%
=======================================
Files 828 828
Lines 39114 39116 +2
Branches 3688 3688
=======================================
+ Hits 24133 24137 +4
+ Misses 14800 14798 -2
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.30% <ø> (ø)` | |
| #python | `61.34% <100.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.26% <0.00%> (-0.04%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `50.76% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.07% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [3d7b805...d97f797](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **decrease** coverage by `0.56%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
- Coverage 61.71% 61.15% -0.57%
==========================================
Files 828 391 -437
Lines 39112 24491 -14621
Branches 3692 0 -3692
==========================================
- Hits 24138 14977 -9161
+ Misses 14793 9514 -5279
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.15% <40.00%> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <33.33%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/addSlice/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL2luZGV4LnRzeA==) | | |
| [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrTXVsdGkuanM=) | | |
| [superset-frontend/src/components/ListView/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvaW5kZXgudHM=) | | |
| ... and [434 more](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#discussion_r500829487
##########
File path: superset/views/utils.py
##########
@@ -494,12 +495,21 @@ def check_datasource_perms(
)
)
- viz_obj = get_viz(
- datasource_type=datasource_type,
- datasource_id=datasource_id,
- form_data=form_data,
- force=False,
- )
+ try:
+ viz_obj = get_viz(
+ datasource_type=datasource_type,
+ datasource_id=datasource_id,
+ form_data=form_data,
+ force=False,
+ )
+ except NoResultFound:
+ raise SupersetSecurityException(
+ SupersetError(
+ error_type=SupersetErrorType.UNKNOWN_DATASOURCE_TYPE_ERROR,
+ level=ErrorLevel.ERROR,
+ message="Could not find viz object",
Review comment:
Good point. I'll add translations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3d7b805`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
=========================================
Coverage ? 60.60%
=========================================
Files ? 391
Lines ? 24492
Branches ? 0
=========================================
Hits ? 14843
Misses ? 9649
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.60% <40.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <33.33%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [3d7b805...d97f797](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **decrease** coverage by `0.37%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
- Coverage 61.71% 61.33% -0.38%
==========================================
Files 828 391 -437
Lines 39112 24491 -14621
Branches 3692 0 -3692
==========================================
- Hits 24138 15022 -9116
+ Misses 14793 9469 -5324
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.33% <45.45%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <40.00%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/injectCustomCss.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2luamVjdEN1c3RvbUNzcy5qcw==) | | |
| [.../dashboard/util/charts/getEffectiveExtraFilters.ts](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRFZmZlY3RpdmVFeHRyYUZpbHRlcnMudHM=) | | |
| [...-frontend/src/SqlLab/reducers/localStorageUsage.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9sb2NhbFN0b3JhZ2VVc2FnZS5qcw==) | | |
| [superset-frontend/src/common/components/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRz) | | |
| [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrTXVsdGkuanM=) | | |
| [...nd/src/messageToasts/containers/ToastPresenter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29udGFpbmVycy9Ub2FzdFByZXNlbnRlci5qc3g=) | | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | | |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | | |
| ... and [429 more](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **increase** coverage by `4.04%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
+ Coverage 61.71% 65.76% +4.04%
==========================================
Files 828 828
Lines 39112 39122 +10
Branches 3692 3693 +1
==========================================
+ Hits 24138 25727 +1589
+ Misses 14793 13284 -1509
+ Partials 181 111 -70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.32% <ø> (?)` | |
| #javascript | `62.33% <ø> (ø)` | |
| #python | `61.33% <40.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <33.33%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (+0.64%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.12% <0.00%> (+1.21%)` | :arrow_up: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.16% <0.00%> (+1.38%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
| [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `92.30% <0.00%> (+1.53%)` | :arrow_up: |
| ... and [165 more](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **decrease** coverage by `0.56%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
- Coverage 61.71% 61.15% -0.57%
==========================================
Files 828 391 -437
Lines 39112 24491 -14621
Branches 3692 0 -3692
==========================================
- Hits 24138 14977 -9161
+ Misses 14793 9514 -5279
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.15% <45.45%> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <40.00%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
| [...-frontend/src/dashboard/containers/FilterScope.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlclNjb3BlLmpzeA==) | | |
| [.../src/explore/components/controls/BoundsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Cb3VuZHNDb250cm9sLmpzeA==) | | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | | |
| ... and [434 more](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3d7b805`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
=========================================
Coverage ? 61.15%
=========================================
Files ? 391
Lines ? 24492
Branches ? 0
=========================================
Hits ? 14978
Misses ? 9514
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `61.15% <40.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <33.33%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [3d7b805...d97f797](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **decrease** coverage by `0.37%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
- Coverage 61.71% 61.33% -0.38%
==========================================
Files 828 391 -437
Lines 39112 24491 -14621
Branches 3692 0 -3692
==========================================
- Hits 24138 15022 -9116
+ Misses 14793 9469 -5324
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.33% <45.45%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <40.00%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | | |
| [...end/src/components/Select/SupersetStyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1N1cGVyc2V0U3R5bGVkU2VsZWN0LnRzeA==) | | |
| [...explore/components/controls/ColorSchemeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wuanN4) | | |
| [...ntend/src/dashboard/util/backgroundStyleOptions.ts](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2JhY2tncm91bmRTdHlsZU9wdGlvbnMudHM=) | | |
| [...erset-frontend/src/SqlLab/components/SaveQuery.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS50c3g=) | | |
| [...-frontend/src/dashboard/util/isDashboardLoading.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkTG9hZGluZy5qcw==) | | |
| [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrTXVsdGkuanM=) | | |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | | |
| ... and [429 more](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#discussion_r500825846
##########
File path: superset/views/utils.py
##########
@@ -494,12 +495,21 @@ def check_datasource_perms(
)
)
- viz_obj = get_viz(
- datasource_type=datasource_type,
- datasource_id=datasource_id,
- form_data=form_data,
- force=False,
- )
+ try:
+ viz_obj = get_viz(
+ datasource_type=datasource_type,
+ datasource_id=datasource_id,
+ form_data=form_data,
+ force=False,
+ )
+ except NoResultFound:
+ raise SupersetSecurityException(
+ SupersetError(
+ error_type=SupersetErrorType.UNKNOWN_DATASOURCE_TYPE_ERROR,
+ level=ErrorLevel.ERROR,
+ message="Could not find viz object",
Review comment:
Will this error surface to the frontend, if yes should we translate it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **decrease** coverage by `1.06%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
- Coverage 61.71% 60.65% -1.07%
==========================================
Files 828 391 -437
Lines 39112 24491 -14621
Branches 3692 0 -3692
==========================================
- Hits 24138 14855 -9283
+ Misses 14793 9636 -5157
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.65% <40.00%> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <33.33%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (-0.83%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
| ... and [437 more](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3d7b805`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
=========================================
Coverage ? 60.55%
=========================================
Files ? 391
Lines ? 24490
Branches ? 0
=========================================
Hits ? 14829
Misses ? 9661
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.55% <40.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <33.33%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [3d7b805...d97f797](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
- Coverage 61.71% 61.70% -0.01%
==========================================
Files 828 828
Lines 39112 39119 +7
Branches 3692 3693 +1
==========================================
+ Hits 24138 24140 +2
- Misses 14793 14798 +5
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.33% <ø> (ø)` | |
| #python | `61.33% <40.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <33.33%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **decrease** coverage by `0.56%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
- Coverage 61.71% 61.15% -0.57%
==========================================
Files 828 391 -437
Lines 39112 24491 -14621
Branches 3692 0 -3692
==========================================
- Hits 24138 14977 -9161
+ Misses 14793 9514 -5279
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.15% <45.45%> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <40.00%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/CodeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvZGVNb2RhbC5qc3g=) | | |
| [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | | |
| ... and [434 more](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **increase** coverage by `4.19%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
+ Coverage 61.71% 65.91% +4.19%
==========================================
Files 828 828
Lines 39112 39122 +10
Branches 3692 3693 +1
==========================================
+ Hits 24138 25786 +1648
+ Misses 14793 13229 -1564
+ Partials 181 107 -74
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.00% <ø> (?)` | |
| #javascript | `62.33% <ø> (ø)` | |
| #python | `61.33% <40.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <33.33%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `60.75% <0.00%> (+1.26%)` | :arrow_up: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.16% <0.00%> (+1.38%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
| [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `92.30% <0.00%> (+1.53%)` | :arrow_up: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
| ... and [167 more](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
- Coverage 61.71% 61.59% -0.13%
==========================================
Files 828 828
Lines 39112 39119 +7
Branches 3692 3693 +1
==========================================
- Hits 24138 24095 -43
- Misses 14793 14843 +50
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.33% <ø> (ø)` | |
| #python | `61.15% <40.00%> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <33.33%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3d7b805`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
=========================================
Coverage ? 60.65%
=========================================
Files ? 391
Lines ? 24492
Branches ? 0
=========================================
Hits ? 14856
Misses ? 9636
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.65% <40.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <33.33%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [3d7b805...d97f797](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11173: fix(viz): downgrade exception for missing viz/datasource
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#issuecomment-704689664
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=h1) Report
> Merging [#11173](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21c8d672a87a71c949ac8ac3c2f373277257fd3b?el=desc) will **decrease** coverage by `2.49%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11173 +/- ##
==========================================
- Coverage 61.71% 59.21% -2.50%
==========================================
Files 828 794 -34
Lines 39112 37853 -1259
Branches 3692 3429 -263
==========================================
- Hits 24138 22415 -1723
- Misses 14793 15246 +453
- Partials 181 192 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.32% <ø> (?)` | |
| #javascript | `?` | |
| #python | `61.33% <45.45%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <40.00%> (-1.54%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.44% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [330 more](https://codecov.io/gh/apache/incubator-superset/pull/11173/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=footer). Last update [21c8d67...f5ebdad](https://codecov.io/gh/apache/incubator-superset/pull/11173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org