[jira] [Commented] (HTRACE-76) Search page: Add +/- filters to search control

["Abraham Elmahrek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341855#comment-14341855 ] 

Abraham Elmahrek commented on HTRACE-76:
----------------------------------------

Thanks for the patch may. This looks great!

# The license header is missing in the new search/field.js page.
# The filters seem broken. It seems like a rebase issue though.

After the above, I'm +1 and we can commit!

> Search page: Add +/- filters to search control
> ----------------------------------------------
>
>                 Key: HTRACE-76
>                 URL: https://issues.apache.org/jira/browse/HTRACE-76
>             Project: HTrace
>          Issue Type: Sub-task
>            Reporter: Abraham Elmahrek
>            Assignee: May Ang
>         Attachments: HTRACE-76.001.patch
>
>
> It would be cool to collapse the controls on the search page into a simple set of filters based on {{field}} and {{op}}. There would be a button to add a filter for a particular field and an associated operation. Obviously, if there's a way to add filters, then there would need to be a way to remove filters as well. So there would need to be a button next to filters to remove them. Perhaps even a reset button.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)