You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "csthomas1 (via GitHub)" <gi...@apache.org> on 2023/04/06 12:29:20 UTC
[GitHub] [pulsar] csthomas1 commented on pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid label errors
csthomas1 commented on PR #19584:
URL: https://github.com/apache/pulsar/pull/19584#issuecomment-1498987410
Sure!
On Wed, Apr 5, 2023 at 3:24 AM Nicolò Boschi ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
>
> good catch! would you mind to add a test case?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/pulsar/pull/19584#pullrequestreview-1372300502>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AQ5QVSJOBEJ2NX5I3JWJL4DW7UMZRANCNFSM6AAAAAAVDNP4DI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org