You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Joel Bernstein (JIRA)" <ji...@apache.org> on 2016/04/25 15:36:13 UTC
[jira] [Comment Edited] (SOLR-8467) CloudSolrStream and FacetStream
should take a SolrParams object rather than a Map to allow
more complex Solr queries to be specified
[ https://issues.apache.org/jira/browse/SOLR-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256338#comment-15256338 ]
Joel Bernstein edited comment on SOLR-8467 at 4/25/16 1:36 PM:
---------------------------------------------------------------
I think this ticket makes sense but I was shying away from it because it ends up touching such a large amount of code.
A couple things to consider before committing:
1) We need some tests for Streaming Expressions with multi-params. It may be that the expression parser needs to be changed to support this. If that's the case we should hold off until we get that working.
2) Let's shoot for getting this into trunk following the 6.1 release. The reason behind this is that it touches enough stuff that it's likely to cause some headaches finishing some fairly big features in trunk which are still getting shaped up for the 6.1
3) Lastly I'd like to spend a little me time reviewing before this gets committed and I'm pretty focused on getting the current 6.1 streaming features together.
If this patch falls behind again I can spend the time catching it up following the 6.1 release.
was (Author: joel.bernstein):
I think this ticket makes sense but I was shying away from it because it ends up touching such a large amount of code.
A couple things to consider before committing:
1) We need some tests for Streaming Expressions with multi-params. It may be that the expression parser needs to be changed to support this. If that's the case we should hold off until we get that working.
2) Let's shoot for getting this into trunk following the 6.1 release. The reason behind this is that it touches enough stuff that it's likely to cause some headaches finishing some fairly big features in trunk which are still getting shaped up for the 6.1
> CloudSolrStream and FacetStream should take a SolrParams object rather than a Map<String, String> to allow more complex Solr queries to be specified
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8467
> URL: https://issues.apache.org/jira/browse/SOLR-8467
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-8467.patch, SOLR-8467.patch, SOLR-8647.patch, SOLR-8647.patch
>
>
> Currently, it's impossible to, say, specify multiple "fq" clauses when using Streaming Aggregation due to the fact that the c'tors take a Map of params.
> Opening to discuss whether we should
> 1> deprecate the current c'tor
> and/or
> 2> add a c'tor that takes a SolrParams object instead.
> and/or
> 3> ???
> I don't see a clean way to go from a Map<String, String> to a (Modifiable)SolrParams, so existing code would need a significant change. I hacked together a PoC, just to see if I could make CloudSolrStream take a ModifiableSolrParams object instead and it passes tests, but it's so bad that I'm not going to even post it. There's _got_ to be a better way to do this, but at least it's possible....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org