[incubator-superset] branch revert-11335-lily/change-chart-title-clicking created (now 9c1377a)

[gr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a change to branch revert-11335-lily/change-chart-title-clicking
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.


      at 9c1377a  Revert "fix: change chart title by clicking (#11335)"

This branch includes the following new commits:

     new 9c1377a  Revert "fix: change chart title by clicking (#11335)"

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[incubator-superset] 01/01: Revert "fix: change chart title by clicking (#11335)"

[gr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch revert-11335-lily/change-chart-title-clicking
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 9c1377a41817d79fe685d372f4be298470f81754
Author: Grace Guo <gr...@airbnb.com>
AuthorDate: Thu Oct 29 14:38:11 2020 -0700

    Revert "fix: change chart title by clicking (#11335)"
    
    This reverts commit 1f04db79f7c1796ac950bb9ca3c2c15530ba9b23.
---
 superset/views/core.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index 1951d98..311e301 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -652,9 +652,7 @@ class Superset(BaseSupersetView):  # pylint: disable=too-many-public-methods
 
         # slc perms
         slice_add_perm = security_manager.can_access("can_add", "SliceModelView")
-        slice_overwrite_perm = (
-            security_manager.can_access("can_edit", "SliceModelView") if slc else False
-        )
+        slice_overwrite_perm = is_owner(slc, g.user) if slc else False
         slice_download_perm = security_manager.can_access(
             "can_download", "SliceModelView"
         )