[GitHub] betodealmeida commented on a change in pull request #6602: Add clear query editors tab

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #6602: Add clear query editors tab
URL: https://github.com/apache/incubator-superset/pull/6602#discussion_r245789872
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/TabbedSqlEditors.jsx
 ##########
 @@ -145,6 +145,13 @@ class TabbedSqlEditors extends React.PureComponent {
   handleSelect(key) {
     if (key === 'add_tab') {
       this.newQueryEditor();
+    } else if (key === 'close_all_tabs') {
+      if (window.confirm('Are you sure you wish to clear all query editors?')) {
 
 Review comment:
   Here it would be better to use the `<Dialog>` component, like you mentioned in Slack. You can see how it's used here: https://github.com/apache/incubator-superset/blob/8307716d723d7e16d3e5dd579a6d9e0f8e5413d8/superset/assets/src/datasource/DatasourceModal.jsx#L42

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org