[GitHub] [flink] XComp commented on a diff in pull request #21501: [FLINK-30397][Connector/Pulsar] Remove Pulsar connector

[GitBox <gi...@apache.org>]

XComp commented on code in PR #21501:
URL: https://github.com/apache/flink/pull/21501#discussion_r1053345426


##########
docs/setup_docs.sh:
##########
@@ -54,6 +58,7 @@ cd tmp
 integrate_connector_docs elasticsearch v3.0.0
 integrate_connector_docs aws v3.0.0
 integrate_connector_docs cassandra v3.0.0
+integrate_connector_docs pulsar main

Review Comment:
   That's going to be changed as soon as pulsar is released?!



##########
docs/setup_docs.sh:
##########
@@ -42,6 +42,10 @@ function integrate_connector_docs {
   theme_dir="../themes/connectors"
   mkdir -p "${theme_dir}"
   rsync -a flink-connector-${connector}/docs/content* "${theme_dir}/"
+  DIR=flink-connector-${connector}/docs/layouts;
+  if [ -e $DIR ];
+    then rsync -a flink-connector-${connector}/docs/layouts* "${theme_dir}/"
+  fi

Review Comment:
   Why is this necessary now and wasn't necessary with the other externalized connectors?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org