You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2006/09/13 16:50:12 UTC

DO NOT REPLY [Bug 40498] New: - connection_pool_timeout is not really respected

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40498>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40498

           Summary: connection_pool_timeout is not really respected
           Product: Tomcat 5
           Version: Unknown
          Platform: Sun
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Connector:AJP
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: georg.zezschwitz@vodafone.com


connection_pool_timeout (or former recycle_timeout) is set to zero as default to
keep the number of AJP 13 connections low. However, many connections stay open,
as the evaluation for closing seems to take place when the *next* requests
arrives. One should assume that "zero" means "close right after the request".
For me, the following patch works fine, but I am not sure enough to suggest it
for submission:

diff -cr tomcat-connectors-1.2.18-src/native/common/jk_ajp_common.c tomcat-conne
ctors-1.2.18-src.new/native/common/jk_ajp_common.c
*** tomcat-connectors-1.2.18-src/native/common/jk_ajp_common.c  Tue Jul 18 09:19
:27 2006
--- tomcat-connectors-1.2.18-src.new/native/common/jk_ajp_common.c      Wed Sep
13 15:42:09 2006
***************
*** 2081,2086 ****
--- 2081,2089 ----
          ajp_worker_t *w = p->worker;

          JK_ENTER_CS(&w->cs, rc);
+         if (p->worker != NULL && p->worker->cache_timeout == 0)
+             p->reuse = JK_FALSE;
+
          if (rc) {
              int i, sock = JK_INVALID_SOCKET;

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 40498] - connection_pool_timeout is not really respected

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40498>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40498


rainer.jung@kippdata.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
          Component|Connector:AJP               |Native:JK




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 40498] - connection_pool_timeout is not really respected

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40498>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40498


rainer.jung@kippdata.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




------- Additional Comments From rainer.jung@kippdata.de  2006-09-14 18:04 -------
We will clarify documentation, that the default value "0" disables the timeout,
not the pooling.

Although we could implement "0" as no pooling and "-1" as no timeout, this
dramatically changes the pool behaviour for all existing configurations. As a
consequence we need to keep the meaning of the default value "0" the same.

If you need to really immediately close each connection after use, the upcoming
version 1.2.19 will include the new JkOption DisableReuse for Apache. You should
carefuly consider, if you really need this behaviour. It is very bad for
performance and usually not a good idea.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org