[GitHub] [kafka] divijvaidya commented on a diff in pull request #12223: MINOR: Correctly mark some tests as integration tests

[GitBox <gi...@apache.org>]

divijvaidya commented on code in PR #12223:
URL: https://github.com/apache/kafka/pull/12223#discussion_r885579531


##########
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java:
##########
@@ -59,6 +60,7 @@
 
 
 @RunWith(Parameterized.class)
+@Tag("integration")

Review Comment:
   Thanks for looking into this @dengziming 
   
   Ah! My bad. `@Category({IntegrationTest.class})` should work with Junit 4. See: https://github.com/apache/kafka/blob/trunk/build.gradle#L470
   
   I found these test running with the command `./gradlew unitTest` based on visual inspection. I have also tried to explore the idea of how to automatically detect if an integration test is running as a unit test but I don't have any solution. The primary blocker is that many files with suffix as "IntegrationTest" actually run as UnitTests (and I think that is expected?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org