You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2016/03/03 03:00:21 UTC
[jira] [Commented] (HTTPCLIENT-1727)
org.apache.http.impl.client.AbstractHttpClient#createClientConnectionManager
Does not account for context class loader
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176969#comment-15176969 ]
Gary Gregory commented on HTTPCLIENT-1727:
------------------------------------------
Patch applied, thank you!
{noformat}
commit -m "[HTTPCLIENT-1727] org.apache.http.impl.client.AbstractHttpClient#createClientConnectionManager Does not account for context class loader." -N E:/vcs/svn/apache/httpcomponents/branches/4.5.x/httpclient/RELEASE_NOTES.txt E:/vcs/svn/apache/httpcomponents/branches/4.5.x/httpclient/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java
Sending E:/vcs/svn/apache/httpcomponents/branches/4.5.x/httpclient/RELEASE_NOTES.txt
Sending E:/vcs/svn/apache/httpcomponents/branches/4.5.x/httpclient/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java
Transmitting file data ...
Committed revision 1733406.
{noformat}
> org.apache.http.impl.client.AbstractHttpClient#createClientConnectionManager Does not account for context class loader
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1727
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1727
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.4.1, 4.5, 4.5.1, 4.5.2
> Reporter: Charles Allen
>
> org.apache.http.impl.client.AbstractHttpClient#createClientConnectionManager Does not account for context class loader.
> This means that only ClientConnectionManager factories visible in AbstractHttpClient's classloader are loadable by AbstractHttpClient
> An example of a failure here is if httpclient and jets3t are loaded in different classloaders, where jets3t is in a child classloader of httpclient's classloader. In such a case httpclient classes will be visible to jets3t, but jets3t's classes will not be visible to httpclient so org.jets3t.service.utils.RestUtils$ConnManagerFactory will not be found.
> The proposed fix against the 4.5.x branch is as follows:
> {code}
> diff --git a/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java b/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java
> index 18a42d7..34c6e0f 100644
> --- a/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java
> +++ b/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AbstractHttpClient.java
> @@ -327,9 +327,15 @@ public abstract class AbstractHttpClient extends CloseableHttpClient {
> final String className = (String) params.getParameter(
> ClientPNames.CONNECTION_MANAGER_FACTORY_CLASS_NAME);
> + final ClassLoader contextLoader = Thread.currentThread().getContextClassLoader();
> if (className != null) {
> try {
> - final Class<?> clazz = Class.forName(className);
> + final Class<?> clazz;
> + if(contextLoader != null) {
> + clazz = Class.forName(className, true, contextLoader);
> + } else {
> + clazz = Class.forName(className);
> + }
> factory = (ClientConnectionManagerFactory) clazz.newInstance();
> } catch (final ClassNotFoundException ex) {
> throw new IllegalStateException("Invalid class name: " + className);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org