You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/02/06 19:07:31 UTC

[GitHub] [maven-shade-plugin] rfscholte commented on a change in pull request #38: [MSHADE-350] enable to rewrite the manifest

rfscholte commented on a change in pull request #38: [MSHADE-350] enable to rewrite the manifest
URL: https://github.com/apache/maven-shade-plugin/pull/38#discussion_r376025839
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/shade/resource/ManifestResourceTransformer.java
 ##########
 @@ -46,6 +46,8 @@
     // Configuration
     private String mainClass;
 
+    private boolean skipRelocators;
 
 Review comment:
   Do we really need this skip parameter? If the manifest file should be transformed and there are relocated classes, just apply them. I see no reason to pollute this class with a skip parameter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services