You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/08 09:23:01 UTC

[GitHub] [apisix-dashboard] xiaotaibai2008 opened a new issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

xiaotaibai2008 opened a new issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719


   ## Issue description
    plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page
   
   ## Expected behavior
    plugin "proxy-rewrite" both found or not found in plugin-config detail page and route detail page
   
   ## How to Reproduce
   
   When creating the route, the "proxy-rewrite" plugin was not found ；
   
   When creating the  plugin-config, the "proxy-rewrite" plugin was found ；
   
   ## Screenshots
   <!-- Add screenshots to help explain your problem if applicable. -->
   ![image](https://user-images.githubusercontent.com/24215735/114001827-e2a25700-988e-11eb-87ce-3f3e481729ff.png)
   
   
   ## Environment
   
   ![image](https://user-images.githubusercontent.com/24215735/114001886-f221a000-988e-11eb-8dc1-40bf259ea665.png)
   
   
   ## Additional context
   <!-- Do you want to solve this issue? or add any other context about the problem here. -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Abbila commented on issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

Posted by GitBox <gi...@apache.org>.

Abbila commented on issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719#issuecomment-815876681


   > yes, this plugin is out of box.
    I have a problem. I can search the rewrite plugin on the route view page，But I don't know it is a bug or a feature。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

Posted by GitBox <gi...@apache.org>.

liuxiran commented on issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719#issuecomment-816028775


   As we have removed the `proxy-rewrite` plugin out of step3 of `/routes/create` page, it should not be found in this page, after checking the latest code,  the current implementation  matched the expectation.
   
   > I have a problem. I can search the rewrite plugin on the route view page，But I don't know it is a bug or a feature。
   
   while checking this issue, I found that in the step2 of `/plugin-template/create` page, `proxy-rewrite` can still be found, that is not as expected, #1723 will fix this. So can this solve your problem @Abbila ?
   
   
   > plugin "proxy-rewrite" both found or not found in plugin-config detail page and route detail page
   
   `plugin-config detail page` means `/plugin/market` right @xiaotaibai2008 ? If so, IMHO `proxy-rewrite` can be found is as expected, because in this page, plugin is configured for the global, not only for the route, so just keep it in.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Abbila commented on issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

Posted by GitBox <gi...@apache.org>.

Abbila commented on issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719#issuecomment-816370063


   @liuxiran @juzhiyuan When editing the route, proxy-rewrite can be found on the preview page of the route, which is the fourth step。
   ![image](https://user-images.githubusercontent.com/17827327/114123170-5e021800-9924-11eb-8123-0f79244b8e9f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Abbila commented on issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

Posted by GitBox <gi...@apache.org>.

Abbila commented on issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719#issuecomment-815673722


   "Request Override" is the proxy-rewrite plugin  #1576


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Engine-AI commented on issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

Posted by GitBox <gi...@apache.org>.

Engine-AI commented on issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719#issuecomment-817448698


   @liuxiran Already resolved in #1721 ，


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

Posted by GitBox <gi...@apache.org>.

liuxiran commented on issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719#issuecomment-816372534


   > @liuxiran @juzhiyuan When editing the route, proxy-rewrite can be found on the preview page of the route, which is the fourth step。
   
   good catch @Abbila ~ there is a missing modification in https://github.com/apache/apisix-dashboard/blob/166137ea9fa42694f09beca3c5c19335b20abc6f/web/src/pages/Route/components/CreateStep4/CreateStep4.tsx#L62
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] xiaotaibai2008 closed issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

Posted by GitBox <gi...@apache.org>.

xiaotaibai2008 closed issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719#issuecomment-815906075


   `Route View`? Could you please take a screenshot?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

Posted by GitBox <gi...@apache.org>.

juzhiyuan closed issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1719: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on issue #1719:
URL: https://github.com/apache/apisix-dashboard/issues/1719#issuecomment-815855725


   yes, this plugin is out of box.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org