You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/11/30 12:29:40 UTC
[GitHub] [cassandra] blerer opened a new pull request #840: CASSANDRA-16305: Remove the duplicated code from CQLTester and SchemaLoader
blerer opened a new pull request #840:
URL: https://github.com/apache/cassandra/pull/840
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #840: CASSANDRA-16305: Remove the duplicated code from CQLTester and SchemaLoader
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #840:
URL: https://github.com/apache/cassandra/pull/840#issuecomment-735777550
I haven't compraed every line changed vs the original version. Just dropped a note on a naming issue. But given mostly is just code de-duplication and shuffling around with a passing CI LGTM +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] blerer closed pull request #840: CASSANDRA-16305: Remove the duplicated code from CQLTester and SchemaLoader
Posted by GitBox <gi...@apache.org>.
blerer closed pull request #840:
URL: https://github.com/apache/cassandra/pull/840
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] blerer commented on pull request #840: CASSANDRA-16305: Remove the duplicated code from CQLTester and SchemaLoader
Posted by GitBox <gi...@apache.org>.
blerer commented on pull request #840:
URL: https://github.com/apache/cassandra/pull/840#issuecomment-737309224
Merged manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on a change in pull request #840: CASSANDRA-16305: Remove the duplicated code from CQLTester and SchemaLoader
Posted by GitBox <gi...@apache.org>.
bereng commented on a change in pull request #840:
URL: https://github.com/apache/cassandra/pull/840#discussion_r532581435
##########
File path: test/unit/org/apache/cassandra/ServerUtils.java
##########
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.HashSet;
+import java.util.Set;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.cassandra.audit.AuditLogManager;
+import org.apache.cassandra.config.DatabaseDescriptor;
+import org.apache.cassandra.db.Keyspace;
+import org.apache.cassandra.db.SystemKeyspace;
+import org.apache.cassandra.db.commitlog.CommitLog;
+import org.apache.cassandra.io.util.FileUtils;
+import org.apache.cassandra.locator.AbstractEndpointSnitch;
+import org.apache.cassandra.locator.InetAddressAndPort;
+import org.apache.cassandra.locator.Replica;
+import org.apache.cassandra.security.ThreadAwareSecurityManager;
+
+/**
+ * Utility methodes used by SchemaLoader and CQLTester to manage the server and its state.
+ *
+ */
+public final class ServerUtils
Review comment:
`ServerUtils` sounds like production code to me. I'd rename it to `ServerTestUtils` i.e. or similar to stress that side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org