You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/08/21 11:36:00 UTC

Review Request 13706: test_snapshots.py : Fixed test case test_03_snapshot_detachedDisk

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13706/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Repository: cloudstack-git


Description
-------

Fixed test_03_snapshot_detachedDisk
This test case was failing due to few invalid paths.

Also changed the ip address in error message. We use ssh_ip of vm for ssh and not ipaddress.


Diffs
-----

  test/integration/component/test_snapshots.py 071702b 

Diff: https://reviews.apache.org/r/13706/diff/


Testing
-------

Tested on KVM advanced setup.


Thanks,

Gaurav Aradhye


Re: Review Request 13706: test_snapshots.py : Fixed test case test_03_snapshot_detachedDisk

Posted by Gaurav Aradhye <ga...@clogeny.com>.

> On Aug. 21, 2013, 9:56 a.m., Prasanna Santhanam wrote:
> > Can you please file a 'Test' issue on jira for this?

Created Test issue:
https://issues.apache.org/jira/browse/CLOUDSTACK-4422


- Gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13706/#review25367
-----------------------------------------------------------


On Aug. 21, 2013, 9:35 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13706/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 9:35 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed test_03_snapshot_detachedDisk
> This test case was failing due to few invalid paths.
> 
> Also changed the ip address in error message. We use ssh_ip of vm for ssh and not ipaddress.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_snapshots.py 071702b 
> 
> Diff: https://reviews.apache.org/r/13706/diff/
> 
> 
> Testing
> -------
> 
> Tested on KVM advanced setup.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 13706: test_snapshots.py : Fixed test case test_03_snapshot_detachedDisk

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13706/#review25367
-----------------------------------------------------------


Can you please file a 'Test' issue on jira for this?

- Prasanna Santhanam


On Aug. 21, 2013, 9:35 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13706/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 9:35 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed test_03_snapshot_detachedDisk
> This test case was failing due to few invalid paths.
> 
> Also changed the ip address in error message. We use ssh_ip of vm for ssh and not ipaddress.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_snapshots.py 071702b 
> 
> Diff: https://reviews.apache.org/r/13706/diff/
> 
> 
> Testing
> -------
> 
> Tested on KVM advanced setup.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 13706: test_snapshots.py : Fixed test case test_03_snapshot_detachedDisk

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13706/#review25369
-----------------------------------------------------------

Ship it!


- Prasanna Santhanam


On Aug. 21, 2013, 9:35 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13706/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 9:35 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed test_03_snapshot_detachedDisk
> This test case was failing due to few invalid paths.
> 
> Also changed the ip address in error message. We use ssh_ip of vm for ssh and not ipaddress.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_snapshots.py 071702b 
> 
> Diff: https://reviews.apache.org/r/13706/diff/
> 
> 
> Testing
> -------
> 
> Tested on KVM advanced setup.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>