You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/02/21 17:37:33 UTC

[kudu-CR] thirdparty: patch libcxx to fix a data race in std::once 

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/6095

to review the following change.

Change subject: thirdparty: patch libcxx to fix a data race in std::once
......................................................................

thirdparty: patch libcxx to fix a data race in std::once

This pulls in a patch from libcxx[1] which fixes a missing memory
barrier in std::once. This is currently causing a lot of TSAN false
positives around SSL initialization.

[1] https://github.com/llvm-mirror/libcxx/commit/4dbd4fcf8626453949625bf36976e668094cfbb1

Change-Id: I0244fdce5346b608bdad31fbd4ab2b8147733b2e
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/libc++-fix-std-once-barriers.patch
2 files changed, 90 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/6095/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0244fdce5346b608bdad31fbd4ab2b8147733b2e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] thirdparty: patch libcxx to fix a data race in std::once

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: thirdparty: patch libcxx to fix a data race in std::once
......................................................................


Patch Set 1: Verified+1

some python "port already in use" flake

-- 
To view, visit http://gerrit.cloudera.org:8080/6095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0244fdce5346b608bdad31fbd4ab2b8147733b2e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] thirdparty: patch libcxx to fix a data race in std::once

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.

Change subject: thirdparty: patch libcxx to fix a data race in std::once
......................................................................


thirdparty: patch libcxx to fix a data race in std::once

This pulls in a patch from libcxx[1] which fixes a missing memory
barrier in std::once. This is currently causing a lot of TSAN false
positives around SSL initialization.

[1] https://github.com/llvm-mirror/libcxx/commit/4dbd4fcf8626453949625bf36976e668094cfbb1

Change-Id: I0244fdce5346b608bdad31fbd4ab2b8147733b2e
Reviewed-on: http://gerrit.cloudera.org:8080/6095
Tested-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/libc++-fix-std-once-barriers.patch
2 files changed, 90 insertions(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Todd Lipcon: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0244fdce5346b608bdad31fbd4ab2b8147733b2e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] thirdparty: patch libcxx to fix a data race in std::once

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: thirdparty: patch libcxx to fix a data race in std::once
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0244fdce5346b608bdad31fbd4ab2b8147733b2e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No