You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Graham Wallis <gr...@uk.ibm.com> on 2018/09/04 15:16:48 UTC

Re: Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68412/
-----------------------------------------------------------

(Updated Sept. 4, 2018, 3:16 p.m.)


Review request for atlas.


Changes
-------

Latest updates include learning mode for entity refreshes, offset and pageSize handling, improved exception handling around use of registry, acceptance of null guid on saveRelationshipReferenceCopy


Repository: atlas


Description
-------

ATLAS-1773: Atlas OMRS Repository Connector


Diffs (updated)
-----

  open-metadata/pom.xml PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasBaseTypeDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasClassificationDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxy.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxyImpl.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/Comparator.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/DSLQueryHelper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/EntityDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/FamousFive.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/ISpringBridge.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSErrorCode.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/SpringBridge.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeDefsByCategory.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeNameUtils.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java PRE-CREATION 
  open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasClassificationDefMapper.java PRE-CREATION 
  open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityDefMapper.java PRE-CREATION 
  open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityMapper.java PRE-CREATION 
  open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipDefMapper.java PRE-CREATION 
  open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipMapper.java PRE-CREATION 
  pom.xml c60a53b0e 
  webapp/pom.xml 78aa81e80 
  webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/web.xml 23dc0637a 


Diff: https://reviews.apache.org/r/68412/diff/3/

Changes: https://reviews.apache.org/r/68412/diff/2-3/


Testing
-------

Unit Testing (approx 80 tests) and Functional Testing of major operations (creation of types, instances, reference copies and proxies).


Thanks,

Graham Wallis


Re: Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

Posted by Graham Wallis <gr...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68412/
-----------------------------------------------------------

(Updated Jan. 10, 2019, 4:52 p.m.)


Review request for atlas.


Changes
-------

Updated connector and event mapper - please note that this version pre-reqs ATLAS-2810 for compile and ATLAS-2939 and ATLAS-2985 for runtime corrections to base function


Repository: atlas


Description
-------

ATLAS-1773: Atlas OMRS Repository Connector


Diffs (updated)
-----

  open-metadata/README.md PRE-CREATION 
  open-metadata/pom.xml PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasBaseTypeDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasClassificationDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxy.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxyImpl.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/Comparator.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/DSLQueryHelper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/EntityDefMapper.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/FamousFive.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/ISpringBridge.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSErrorCode.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/SpringBridge.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeDefsByCategory.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeNameUtils.java PRE-CREATION 
  open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java PRE-CREATION 
  open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasClassificationDefMapper.java PRE-CREATION 
  open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityDefMapper.java PRE-CREATION 
  open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityMapper.java PRE-CREATION 
  open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipDefMapper.java PRE-CREATION 
  open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipMapper.java PRE-CREATION 
  pom.xml 49fe7de14bf52f9a1de7153eab0484f42e25e37a 
  webapp/pom.xml e1988c34863053489c3331a994b328adc92347b0 
  webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/web.xml 23dc0637a8b521ab89a16ec8b03895cdaf8bc7d8 


Diff: https://reviews.apache.org/r/68412/diff/4/

Changes: https://reviews.apache.org/r/68412/diff/3-4/


Testing (updated)
-------

Unit Testing (approx 80 tests) and Functional Testing of major operations (creation of types, instances, reference copies and proxies).
Clean run through Egeria CTS test suite.


Thanks,

Graham Wallis