You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/17 20:20:00 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request #5536: Fix atscfg comparing pointers not values

rob05c opened a new pull request #5536:
URL: https://github.com/apache/trafficcontrol/pull/5536


   This causes the config gen to think CDNs are different when they aren't, causing it to think no servers on the same CDN are assigned, omitting a max_origin_connections entry.
   
   Includes modifying the tests to have different pointers, so the tests will fail without this fix.
   Includes changelog.
   No docs, no interface change.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Generate config on a Mid with MaxOriginConnetions on a DS, verify max_origin_connections is inserted in header rewrite file.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   - 5.0
   - 5.1
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] jpappa200 commented on pull request #5536: Fix atscfg comparing pointers not values

Posted by GitBox <gi...@apache.org>.
jpappa200 commented on pull request #5536:
URL: https://github.com/apache/trafficcontrol/pull/5536#issuecomment-781607732


   This looks good to me. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #5536: Fix atscfg comparing pointers not values

Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #5536:
URL: https://github.com/apache/trafficcontrol/pull/5536


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp commented on pull request #5536: Fix atscfg comparing pointers not values

Posted by GitBox <gi...@apache.org>.
rawlinp commented on pull request #5536:
URL: https://github.com/apache/trafficcontrol/pull/5536#issuecomment-781650094


   @rob05c this seems to fix https://github.com/apache/trafficcontrol/issues/5427 -- does it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rob05c commented on pull request #5536: Fix atscfg comparing pointers not values

Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #5536:
URL: https://github.com/apache/trafficcontrol/pull/5536#issuecomment-781652054


   I'm not entirely clear on the scope of that case. But yes, with this fix, ATC will auto-calculate the max origin connections per mid.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org