[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1629: Flink backend implementation

[GitBox <gi...@apache.org>]

pan3793 commented on a change in pull request #1629:
URL: https://github.com/apache/incubator-kyuubi/pull/1629#discussion_r775391627



##########
File path: build/dist
##########
@@ -144,14 +152,17 @@ HIVE_VERSION=$("$MVN" help:evaluate -Dexpression=hive.version $@ 2>/dev/null\
     | grep -v "WARNING"\
     | tail -n 1)
 
-echo "Building Kyuubi package of version $VERSION against Spark version - $SPARK_VERSION"
+echo "Building Kyuubi package of version $VERSION against Flink $FLINK_VERSION, Spark $SPARK_VERSION"
 
-SUFFIX="-$NAME"
-if [[ "$NAME" == "none" ]]; then
-  if [[ "$SPARK_PROVIDED" == "true" ]]; then
-    SUFFIX=""
-  else
-    SUFFIX="-spark-${SPARK_VERSION:0:3}-hadoop${SPARK_HADOOP_VERSION}"
+if [[ "$NAME" != "none" ]]; then

Review comment:
       `build/dist --tgz --flink-provided --spark-provided` => `apache-kyuubi-1.5.0-SNAPSHOT-bin.tgz`
   `build/dist --tgz --name custom` => `apache-kyuubi-1.5.0-SNAPSHOT-bin-custom.tgz`
   `build/dist --tgz --spark-provided` => `apache-kyuubi-1.5.0-SNAPSHOT-bin-flink-1.14.tgz`
   `build/dist --tgz --flink-provided` => `apache-kyuubi-1.5.0-SNAPSHOT-spark-3.1-hadoop3.2.tgz`
   `build/dist --tgz` => `apache-kyuubi-1.5.0-SNAPSHOT-bin-flink-1.14-spark-3.1-hadoop3.2.tgz`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org