You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by st...@apache.org on 2015/06/18 00:06:09 UTC
cordova-lib git commit: CB-9163 fixed failing tests
Repository: cordova-lib
Updated Branches:
refs/heads/master d7f8ebdec -> b6727ba9e
CB-9163 fixed failing tests
Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/b6727ba9
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/b6727ba9
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/b6727ba9
Branch: refs/heads/master
Commit: b6727ba9e465a733ce07ac222b17b46ab975f714
Parents: d7f8ebd
Author: Steve Gill <st...@gmail.com>
Authored: Wed Jun 17 15:06:02 2015 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Wed Jun 17 15:06:02 2015 -0700
----------------------------------------------------------------------
cordova-lib/spec-plugman/install-browserify.spec.js | 4 ++--
cordova-lib/spec-plugman/install.spec.js | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/b6727ba9/cordova-lib/spec-plugman/install-browserify.spec.js
----------------------------------------------------------------------
diff --git a/cordova-lib/spec-plugman/install-browserify.spec.js b/cordova-lib/spec-plugman/install-browserify.spec.js
index e236779..4e7e0c7 100644
--- a/cordova-lib/spec-plugman/install-browserify.spec.js
+++ b/cordova-lib/spec-plugman/install-browserify.spec.js
@@ -480,7 +480,7 @@ describe('install', function() {
expect(''+done).toContain('"git" command line tool is not installed: make sure it is accessible on your PATH.');
});
});
- it('should throw if plugin version is less than the minimum requirement', function(){
+ it('should not fail if plugin version is less than the minimum requirement. Instead skip.', function(){
spyOn(semver, 'satisfies').andReturn(false);
exec.andCallFake(function(cmd, cb) {
cb(null, '0.0.1\n');
@@ -490,7 +490,7 @@ describe('install', function() {
});
waitsFor(function(){ return done; }, 'install promise never resolved', 200);
runs(function() {
- expect(''+done).toContain('Plugin doesn\'t support this project\'s cordova version. cordova: 0.0.1, failed version requirement: >=2.3.0');
+ expect(''+done).toMatch(true);
});
});
});
http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/b6727ba9/cordova-lib/spec-plugman/install.spec.js
----------------------------------------------------------------------
diff --git a/cordova-lib/spec-plugman/install.spec.js b/cordova-lib/spec-plugman/install.spec.js
index 751268f..dc42ba0 100644
--- a/cordova-lib/spec-plugman/install.spec.js
+++ b/cordova-lib/spec-plugman/install.spec.js
@@ -473,7 +473,7 @@ describe('install', function() {
expect(''+done).toContain('"git" command line tool is not installed: make sure it is accessible on your PATH.');
});
});
- it('should throw if plugin version is less than the minimum requirement', function(){
+ it('should not fail when trying to install plugin less than minimum version. Skip instead ', function(){
spyOn(semver, 'satisfies').andReturn(false);
exec.andCallFake(function(cmd, cb) {
cb(null, '0.0.1\n');
@@ -483,7 +483,7 @@ describe('install', function() {
});
waitsFor(function(){ return done; }, 'install promise never resolved', 200);
runs(function() {
- expect(''+done).toContain('Plugin doesn\'t support this project\'s cordova version. cordova: 0.0.1, failed version requirement: >=2.3.0');
+ expect(''+done).toMatch(true);
});
});
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org