You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by df...@apache.org on 2009/03/11 05:44:34 UTC

svn commit: r752367 - in /commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils: BasicRowProcessor.java QueryLoader.java ResultSetIterator.java

Author: dfabulich
Date: Wed Mar 11 04:44:33 2009
New Revision: 752367

URL: http://svn.apache.org/viewvc?rev=752367&view=rev
Log:
Incorporating sebb's dbutils.patch for DBUTILS-51.

Modified:
    commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BasicRowProcessor.java
    commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryLoader.java
    commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/ResultSetIterator.java

Modified: commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BasicRowProcessor.java
URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BasicRowProcessor.java?rev=752367&r1=752366&r2=752367&view=diff
==============================================================================
--- commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BasicRowProcessor.java (original)
+++ commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BasicRowProcessor.java Wed Mar 11 04:44:33 2009
@@ -60,7 +60,7 @@
     /**
      * Use this to process beans.
      */
-    private BeanProcessor convert = null;
+    private final BeanProcessor convert;
 
     /**
      * BasicRowProcessor constructor.  Bean processing defaults to a 

Modified: commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryLoader.java
URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryLoader.java?rev=752367&r1=752366&r2=752367&view=diff
==============================================================================
--- commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryLoader.java (original)
+++ commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryLoader.java Wed Mar 11 04:44:33 2009
@@ -46,7 +46,7 @@
     /**
      * Maps query set names to Maps of their queries.
      */
-    private Map queries = new HashMap();
+    private final Map queries = new HashMap();
 
     /**
      * QueryLoader constructor.

Modified: commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/ResultSetIterator.java
URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/ResultSetIterator.java?rev=752367&r1=752366&r2=752367&view=diff
==============================================================================
--- commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/ResultSetIterator.java (original)
+++ commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/ResultSetIterator.java Wed Mar 11 04:44:33 2009
@@ -37,19 +37,19 @@
     /**
      * The wrapped <code>ResultSet</code>.
      */
-    private ResultSet rs = null;
+    private final ResultSet rs;
     
     /**
      * The processor to use when converting a row into an Object[].
      */
-    private RowProcessor convert = new BasicRowProcessor();
+    private final RowProcessor convert;
 
     /**
      * Constructor for ResultSetIterator.
      * @param rs Wrap this <code>ResultSet</code> in an <code>Iterator</code>.
      */
     public ResultSetIterator(ResultSet rs) {
-        this.rs = rs;
+        this(rs , new BasicRowProcessor());
     }
     
     /**