[GitHub] [pulsar] 315157973 commented on a change in pull request #14102: [#14101] [schema] making schema registry configurable

[GitBox <gi...@apache.org>]

315157973 commented on a change in pull request #14102:
URL: https://github.com/apache/pulsar/pull/14102#discussion_r806475068



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryService.java
##########
@@ -42,19 +43,26 @@
         return checkers;
     }
 
-    static SchemaRegistryService create(SchemaStorage schemaStorage, Set<String> schemaRegistryCompatibilityCheckers) {
+    static SchemaRegistryService create(String schemaRegistryClassName, SchemaStorage schemaStorage,
+          Set<String> schemaRegistryCompatibilityCheckers) {
         if (schemaStorage != null) {
             try {
                 Map<SchemaType, SchemaCompatibilityCheck> checkers = getCheckers(schemaRegistryCompatibilityCheckers);
                 checkers.put(SchemaType.KEY_VALUE, new KeyValueSchemaCompatibilityCheck(checkers));
-                return SchemaRegistryServiceWithSchemaDataValidator.of(
-                        new SchemaRegistryServiceImpl(schemaStorage, checkers));
+
+                SchemaRegistryService schemaRegistryService = (SchemaRegistryService) Class
+                      .forName(schemaRegistryClassName).getDeclaredConstructor(SchemaStorage.class, Map.class)
+                      .newInstance(schemaStorage, checkers);
+
+                return SchemaRegistryServiceWithSchemaDataValidator.of(schemaRegistryService);
             } catch (Exception e) {
                 LOG.warn("Unable to create schema registry storage, defaulting to empty storage", e);
             }
         }
         return new DefaultSchemaRegistryService();
     }
 
+    void initialize(ServiceConfiguration configuration);

Review comment:
       Why add this interface?  It doesn't seem necessary




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org