[GitHub] [pulsar-client-python] shibd commented on a diff in pull request #119: Fetch writer schema to decode Avro messages

["shibd (via GitHub)" <gi...@apache.org>]

shibd commented on code in PR #119:
URL: https://github.com/apache/pulsar-client-python/pull/119#discussion_r1203755497


##########
pulsar/schema/schema_avro.py:
##########
@@ -40,6 +42,8 @@ def __init__(self, record_cls, schema_definition=None):
                 self._schema = record_cls.schema()
             else:
                 self._schema = schema_definition
+            self._writer_schemas = dict()

Review Comment:
   This field name defines differently with the Java client.
   
   In JAVA client
   - self._schama is WriterSchema. 
   - self._writer_schemas is ReaderSchema.
   
   https://github.com/apache/pulsar/blob/b31c5a6a325728b5dc5faebd1a33386952d733d5/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java#L57-L59
   
   It‘s better to keep consistent?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org